Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite based on v5 #23

Open
3 of 4 tasks
Download opened this issue Jul 24, 2017 · 1 comment
Open
3 of 4 tasks

Update test suite based on v5 #23

Download opened this issue Jul 24, 2017 · 1 comment
Milestone

Comments

@Download
Copy link
Owner

Download commented Jul 24, 2017

No need to fix all tests yet. Instead just create issues for them and people might be able to lend us a hand in fixing them.

  • Copy tests from nfl/react-helmet v5
  • Change build scripts to use the new tests
  • Remove old tests
  • Change tests to depend on Preact i.s.o on React
@Download Download added this to the v5 milestone Jul 24, 2017
This was referenced Jul 24, 2017
@Download
Copy link
Owner Author

We need to change the tests to depend on Preact

Because this hasn't been done yet the tests don't even transpile a.t.m. until we fix this.

TEST RESULTS AFTER UPDATE

C:\ws\preact-helmet>npm test

> [email protected] pretest C:\ws\preact-helmet
> npm run clean && npm run lint && npm run compile

npm WARN invalid config loglevel="notice"

> [email protected] clean C:\ws\preact-helmet
> rimraf lib build es

npm WARN invalid config loglevel="notice"

> [email protected] lint C:\ws\preact-helmet
> eslint --ignore-path .gitignore -- .

C:\ws\preact-helmet\test\HelmetDeclarativeTest.js
   5:19  error  Unable to resolve path to module 'react'                  import/no-unresolved
   6:22  error  Unable to resolve path to module 'react-dom'              import/no-unresolved
   7:25  error  Unable to resolve path to module 'react-dom/server'       import/no-unresolved
   8:9   error  Helmet not found in '../src/Helmet'                       import/named
   9:9   error  HTML_TAG_MAP not found in '../src/HelmetConstants'        import/named
  10:35  error  Unable to resolve path to module '../src/HelmetUtils.js'  import/no-unresolved

C:\ws\preact-helmet\test\HelmetTest.js
  4:19  error  Unable to resolve path to module 'react'                  import/no-unresolved
  5:22  error  Unable to resolve path to module 'react-dom'              import/no-unresolved
  6:25  error  Unable to resolve path to module 'react-dom/server'       import/no-unresolved
  7:9   error  Helmet not found in '../src/Helmet'                       import/named
  8:35  error  Unable to resolve path to module '../src/HelmetUtils.js'  import/no-unresolved

✖ 11 problems (11 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] lint: `eslint --ignore-path .gitignore -- .`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Frank\AppData\Roaming\npm-cache\_logs\2017-07-25T21_00_34_759Z-debug.log
npm ERR! Test failed.  See above for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant