Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for html tags format #17

Closed
siddharthkp opened this issue Jun 6, 2017 · 6 comments
Closed

Support for html tags format #17

siddharthkp opened this issue Jun 6, 2017 · 6 comments

Comments

@siddharthkp
Copy link
Collaborator

Does preact-helmet support html tags like react-helmet?

https://github.com/nfl/react-helmet#example:

<Helmet>
  <meta charSet="utf-8" />
  <title>My Title</title>
  <link rel="canonical" href="http://mysite.com/example" />
</Helmet>
@Download
Copy link
Owner

Download commented Jun 6, 2017

Unfortunately, not (yet).

When I ported Helmet it was at 4.x. They added these new features later. I'll probably port the new version at some point but I don't have the time atm. PRs are always welcome of course! ;)

@siddharthkp
Copy link
Collaborator Author

@Download How should I go about it? If I know the diff between the 2 repos, it can hopefully be automated and always be in sync with react-helmet (at least minor versions)

@Download
Copy link
Owner

Download commented Jun 6, 2017

Both React Helmet as well as Preact itself have gone up major versions.

If you want to try it, just fork React Helmet v5 and change it to work with Preact. You can peek in the v4 version of the port to see how I dealt with some of the differences. That's how I would do it at least.

@siddharthkp
Copy link
Collaborator Author

@Download oh okay. Thanks, I'm going to try that.

@Download
Copy link
Owner

@siddharthkp

So more people are requesting this.
I left you a bit dangling the previous time. Sorry about that.
It would probably help a lot if you didn't have to start from scratch :)

Look here for some guidance and I'll try to help out getting you started:
#25

@siddharthkp
Copy link
Collaborator Author

No worries, #25 is super useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants