Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "magic" importing of components/containers/etc. #52

Open
bmbarker90 opened this issue Sep 15, 2016 · 1 comment
Open

Remove "magic" importing of components/containers/etc. #52

bmbarker90 opened this issue Sep 15, 2016 · 1 comment

Comments

@bmbarker90
Copy link
Contributor

I propose that we remove "magic" importing of things. I think it gets rid of one of the advantages and reasons why to use es6 modules. I think we should require people to be explicit about what they are including in their files and mindful of how much stuff they are importing.

Furthermore, it prevents certain bugs that are very hard to debug. For example, let's assume that for whatever reason someone deleted BarComponent that was being used in FooBarModule by FooComponent. If I am not being explicit about importing BarComponent, the only way that I know that it isn't there anymore is that it doesn't render BarComponent at runtime. That is really hard to debug. If I'm explicitly importing BarComponent, the app will fail to build and I will realize that BarComponent is indeed needed and be able to see where it is needed.

@sldavidson
Copy link
Contributor

I am going to have to agree with Ben on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants