Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect command bytecode offset desync when exporting to .asm #331

Open
Gumball2415 opened this issue Jan 24, 2025 · 0 comments
Open

Effect command bytecode offset desync when exporting to .asm #331

Gumball2415 opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working nsf-driver sound engine used in NSF/assembly file export

Comments

@Gumball2415
Copy link
Collaborator

when exporting to .asm, CPatternCompiler::Command() determines additional effect command offsets depending on whether the module is multichip or single chip.

as of Dn-FT v0.5.1.0, this logic is broken due to not implementing the same "glob" multichip logic in e67e701.
@Gumball2415 Gumball2415 added bug Something isn't working nsf-driver sound engine used in NSF/assembly file export labels Jan 24, 2025
@Gumball2415 Gumball2415 mentioned this issue Jan 24, 2025
Open
Gumball2415 added a commit that referenced this issue Jan 24, 2025
@Gumball2415
NSF Driver: include "glob" logic in effect command
a9202e0 
This fixes #331.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working nsf-driver sound engine used in NSF/assembly file export
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gumball2415