Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to match_citations() #9

Open
5 tasks
allenbaron opened this issue Nov 11, 2022 · 0 comments
Open
5 tasks

Updates to match_citations() #9

allenbaron opened this issue Nov 11, 2022 · 0 comments

Comments

@allenbaron
Copy link
Collaborator

  • Skip matching when one vector is all NA and include message indicating skip.
  • Add (optional?) output of number of matches identified by each publication type (when more than one).
  • Update message to make sort order more explicit (e.g. pmid > pmcid).
  • Ensure matches by DOI are case insensitive.

Also consider:

  • Add warning when an ID column is found in both data.frames but no matches are identified.
allenbaron added a commit that referenced this issue Nov 11, 2022
@allenbaron
Add test for DOI case insensitive matching [FAIL]
5ec2136 
DOIs are case insensitive but R is not, meaning correct DOI
matches may be missed.

DOI case insensitivity:
https://www.doi.org/doi_handbook/2_Numbering.html#2.4

Added need for fix as item to issue #9.
allenbaron added a commit that referenced this issue Nov 11, 2022
@allenbaron
Make match_citations() DOI matches case insensitive [PASS]
b4d72cc 
Addresses item in issue #9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allenbaron