Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperion testing 28/11 #692

Closed
DominicOram opened this issue Nov 29, 2024 · 1 comment
Closed

Hyperion testing 28/11 #692

DominicOram opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels

Comments

@DominicOram
Copy link
Contributor

Did some brief testing of #685 on the beamline. Found some minor issues:

Error of:

ERROR:root:device `array_data` raised unexpected exception TypeError
Traceback (most recent call last):
  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.1a/mx-bluesky/.venv/lib/python3.11/site-packages/ophyd_async/core/_device.py", line 172, in connect
    await self._connect_task
  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.1a/mx-bluesky/.venv/lib/python3.11/site-packages/ophyd_async/core/_signal.py", line 67, in connect_real
    await self.backend.connect(timeout)
  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.1a/mx-bluesky/.venv/lib/python3.11/site-packages/ophyd_async/epics/core/_p4p.py", line 324, in connect
    self.converter = make_converter(self.datatype, self.initial_values)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dls_sw/i03/software/bluesky/mx-bluesky_v1.4.1a/mx-bluesky/.venv/lib/python3.11/site-packages/ophyd_async/epics/core/_p4p.py", line 255, in make_converter
    raise TypeError(
TypeError: BL03I-DI-OAV-01:PVA:ARRAY with inferred datatype ndarray from typeid='epics:nt/NTNDArray:1.0' specifier='U' cannot be coerced to Array1D[np.uint8]

Fixed by changing the type to np.ndarray.

The docs at https://diamondlightsource.github.io/mx-bluesky/main/developer/general/how-to/deploy-a-release.html say to pip install dodal after mx_bluesky this ends up with the dodal from pypi, not the local one as:

  1. Pip installing mx_bluesky installs the pypi version
  2. If you try and pip install the local version pip recognises that you have the one from pypi and just says there's no need to install anything new
@rtuck99
Copy link
Contributor

rtuck99 commented Jan 6, 2025

@rtuck99 rtuck99 closed this as completed Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants