Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract number of filters for attenuator device #971

Open
olliesilvester opened this issue Dec 19, 2024 · 0 comments
Open

Abstract number of filters for attenuator device #971

olliesilvester opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@olliesilvester
Copy link
Collaborator

olliesilvester commented Dec 19, 2024 •
edited
Loading

Our BinaryFilterAttenuator currently only works for a 16 filter attenuator. We should abstract away the number of filters so we can use the same device for any number, using DeviceVector

Acceptance Criteria

  • Attenuator class accepts number of filters as a parameter
  • Tests pass, including dodal connect for the beamlines which use this device
@olliesilvester olliesilvester added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olliesilvester