Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job that fails PRs if tests are taking >1s #1003

Open
DominicOram opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1033
Open

Add CI job that fails PRs if tests are taking >1s #1003

DominicOram opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1033
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

All unit tests should be fast running and so not take >1s each. If they are taking longer it is most likely due to an issue with poor mocking. To make sure we enforce this we should add a CI check on a PR that confirms that no tests individually took too long.

The durations can be found with pytest /tests --durations=0 but this isn't very machine readable so it may be worth a look around to see if we can get them out in a nicer way

Acceptance Criteria

  • CI blocks PRs where an individual test is taking longer than 1s
@DominicOram DominicOram added the good first issue Good for newcomers label Jan 24, 2025
@stan-dot stan-dot linked a pull request Feb 3, 2025 that will close this issue
4 tasks
@stan-dot stan-dot linked a pull request Feb 3, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant