Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timing metrics #10

Open
DominicOram opened this issue Sep 5, 2022 · 3 comments
Open

Add timing metrics #10

DominicOram opened this issue Sep 5, 2022 · 3 comments
Labels
Design Discussion about the internal design of the repo Developer Experience

Comments

@DominicOram
Copy link
Contributor

As discussed in DiamondLightSource/hyperion#129 it would be useful to have timing metrics for how long actions take.
@DominicOram DominicOram mentioned this issue Sep 5, 2022
Open
@stan-dot
Copy link
Contributor

question: should this be handled at the dodal level or mx_hyperion / blueapi level?

AFAIK the former already has telemetry and for blueapi it is investigated DiamondLightSource/blueapi#96

@stan-dot stan-dot added Developer Experience Design Discussion about the internal design of the repo labels Dec 2, 2024
@stan-dot
Copy link
Contributor

stan-dot commented Dec 2, 2024

alternative place for this functionality would be in blueapi, @callumforrester thoughts?

@DominicOram
Copy link
Contributor Author

I don't think it's an alternative, I think we need to be able to add metrics with varying granularity across the whole stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design Discussion about the internal design of the repo Developer Experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DominicOram @stan-dot