New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in onRestoreInstanceState #3

Open

Shipaaaa opened this issue Aug 5, 2019 · 1 comment

Contributor

Shipaaaa commented Aug 5, 2019 •

edited

Loading

Hello!

I found a bug in the onRestoreInstanceState method. You set maxScale value in minScale on 89 line.

    this.minScale = (float)bundle.getInt("minScale");
    this.minScale = (float)bundle.getInt("maxScale");

Can you fix this in the near future?

The text was updated successfully, but these errors were encountered:

Shipaaaa mentioned this issue

Bug with maxScale in onRestoreInstanceState fixed. #4

Merged

abbas-oveissi commented Jul 16, 2020

I think it's better to use getFloat method. is there any reason for using getInt and then cast it to float type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment