reportUnusedCallResult special casing for reveal_type doesn't work when aliased

[abelcheung]

Minimal example:

from typing import reveal_type as rt

def test_inferred() -> None:
    x = 1
    rt(x)

The reportUnusedCallResult rule is triggered in this case, with exit code = 1. However, if I don't rename reveal_type(), then the rule is not triggered, and exit code = 0.

Actually pyright has same problem if I forcefully add {"reportUnusedCallResult":"warning"} to pyrightconfig.json. But since basedpyright opt to turn on this rule by default but not pyright, do you think if it worths fixing in basedpyright?

[abelcheung]

Hmm, on second thought, it should have been affected by the rule as well, but given how people commonly use reveal_type(), only this func got special treatment. What's your opinion here? I have disabled this rule locally in my tests, so it's fine either way.

[DetachHead]

yeah reveal_type is special cased here. related issues: #315 #544

[KotlinIsland]

also this:

def reveal_type() -> int:
    return 1

reveal_type()  # no error

def foo() -> int:
    return 1

foo()  # error

playground