Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using ADTypes rather than Bool for autodiff #2029

Open
visr opened this issue Feb 2, 2025 · 0 comments
Open

Start using ADTypes rather than Bool for autodiff #2029

visr opened this issue Feb 2, 2025 · 0 comments
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Feb 2, 2025

I noticed in the test logs a new deprecation warning:

┌ Warning: Using a `Bool` for keyword argument `autodiff` is deprecated. Please use an `ADType` specifier.
│   caller = _process_AD_choice(ad_alg::Bool, chunksize::Val{0}, diff_type::Val{:forward}) at misc_utils.jl:147
└ @ OrdinaryDiffEqCore ~/.julia/packages/OrdinaryDiffEqCore/33WQj/src/misc_utils.jl:147

See https://github.com/SciML/ADTypes.jl.
In our config we have autodiff = true/false. I guess we'd keep that for now and just map true to AutoForwardDiff.

@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 2, 2025
@visr visr added the core Issues related to the computational core in Julia label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia
Projects
Status: To do
Development

No branches or pull requests

1 participant