Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into tokenization #2

Open
DavidNemeskey opened this issue Jan 24, 2020 · 0 comments
Open

Look into tokenization #2

DavidNemeskey opened this issue Jan 24, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@DavidNemeskey
Copy link
Owner

The original BERT was trained with raw text, and punctuation marks were generally seen attached to words. In emBERT, we take the output of emToken, so punctuation marks are tokens in their own right. This discrepancy might affect performance.

  1. Check if this is really the case. The basic tokenization procedure does split punctuation from the end of words, so the problem might not be as acute as it seems at first sight.
  2. Merge punctuation tokens with the words before sending them to the BERT model.
  3. Alternatively, skip emToken altogether?
@DavidNemeskey DavidNemeskey added the enhancement New feature or request label Jan 24, 2020
@DavidNemeskey DavidNemeskey self-assigned this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant