Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename functions and quantities of interest #26

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Rename functions and quantities of interest #26

merged 3 commits into from
Feb 27, 2024

Conversation

joaopfonseca
Copy link
Member

What does this PR do?

Fixes #24 , Fixes #25

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is welcome to review the PR. Before you start
reviewing, make sure you go through the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@joaopfonseca joaopfonseca changed the title Renaming Rename functions and quantities of interest Feb 27, 2024
@joaopfonseca joaopfonseca merged commit adbace6 into main Feb 27, 2024
13 checks passed
@joaopfonseca joaopfonseca deleted the renaming branch February 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename QoI's with ranking in the name to rank Rename scores_to_rank to scores_to_ordering
1 participant