From fa0948fcbc9d9c1d2fe01071733e46b409717802 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 30 Oct 2024 16:46:46 +0000 Subject: [PATCH] chore(crashtracking): add python version to crashtracker tags [backport 2.13] (#10733) Backport fe5b42f38544f44c56da6ac409340c23914b516b from #10720 to 2.13. During escalations it's currently difficult to find the exact Python version relevant for a defect. This is a simple fix for that. I'm recommending a backport because 1. The fix is simple 2. 2.11 and onward introduce crashtracker, and we're still dealing with crashes from those versions ## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: David Sanchez <838104+sanchda@users.noreply.github.com> --- ddtrace/internal/core/crashtracking.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ddtrace/internal/core/crashtracking.py b/ddtrace/internal/core/crashtracking.py index a36d9639fed..2f06caf5d0c 100644 --- a/ddtrace/internal/core/crashtracking.py +++ b/ddtrace/internal/core/crashtracking.py @@ -28,11 +28,14 @@ def start() -> bool: if not is_available: return False + import platform + crashtracker.set_url(crashtracker_config.debug_url or agent.get_trace_url()) crashtracker.set_service(config.service) crashtracker.set_version(config.version) crashtracker.set_env(config.env) crashtracker.set_runtime_id(get_runtime_id()) + crashtracker.set_runtime_version(platform.python_version()) crashtracker.set_library_version(version.get_version()) crashtracker.set_alt_stack(bool(crashtracker_config.alt_stack)) crashtracker.set_wait_for_receiver(bool(crashtracker_config.wait_for_receiver))