Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR in DateTimePickerModule is not an NgModule #6

Closed
J1G4RSH4H opened this issue Mar 23, 2017 · 8 comments
Closed

ERROR in DateTimePickerModule is not an NgModule #6

J1G4RSH4H opened this issue Mar 23, 2017 · 8 comments

Comments

@J1G4RSH4H
Copy link

hello,
while importing this plugin into my app.module.ts gives me the following error:
ERROR in DateTimePickerModule is not an NgModule.

@jurafa
Copy link

jurafa commented Mar 23, 2017

Same for me with version 2.0.0 and higher.
Version 1.0.7 compiles without problem.
I am using angular/cli with webpack.

@DanielYKPan
Copy link
Owner

@jigsshah @jurafa
I will check for it...

@jigsshah are you running it using SystemJS or Webpack?

@DanielYKPan
Copy link
Owner

@jigsshah @jurafa
I looked for the problem you mentions. And I found some packages building with Angular 2 have the some problem too. I found this one.

I will look at it and try to fix it today.
Thanks guys.

@J1G4RSH4H
Copy link
Author

Hello Daniel,
First of all thanks for you looking to issue and providing your time.
My Angular version is angular/compiler-cli": "^2.3.1" and i am using SystemJS Package Loader

@DanielYKPan
Copy link
Owner

@jigsshah
Yes, I found the problem similar to other angular2 package like this one. I am working on it right now.

@J1G4RSH4H
Copy link
Author

Hello Daniel,
Can you let me know if we can have or use the existing plugin in the inline mode also as like bootstrap one like.
Thanks

@DanielYKPan
Copy link
Owner

@jigsshah @jurafa
Guys, I fixed the problem. Please update the package to version 2.0.8.

@jurafa
If you running the package in the latest angular-cli, this package still would not work. This is because the latest angular/cli is running the AngularJS 4.0.0, and AngularJS 4.0.0 animation has its own module (not in @angular/core any more). This causes the package crash. I would create a new ng4-date-time-picker package.

@jurafa
Copy link

jurafa commented Mar 25, 2017

Thank you for your time.
I am using Angular 2 with WebPack. I will try the fix soon.
BTW: The naming conventions have slightly changed and naming package ng*-date-time-picker is not recommended anymore according to this: http://angularjs.blogspot.cz/2016/12/ok-let-me-explain-its-going-to-be.html (Quote: "Also, we should start avoiding GitHub/NPM libraries prefixed with ng2- or angular2-.")

pedro-pv pushed a commit to pedro-pv/date-time-picker that referenced this issue Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants