-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Query Tracing #42
Comments
About the paging, I can be wrong but if it's "unpaged" when your result is above the base paging (100), probably it will accuse as let mut query: Query = Query::new("SELECT a, b FROM ks.t");
query.set_page_size(1000); // Debugging purposes maybe? Probably we can find a better implementation for that, but let's keep it simple for now and make it work. |
Idk because I'm querying the |
So we don't have a problem here. Let's implement it and in the next driver version we can check how it gonna be. |
Currently, the driver does not provide a straightforward way to retrieve tracing information alongside the query results.
Desired API:
To make query tracing accessible, I propose adding a new method
execute_with_tracing
to thesession
object. This method will execute a query and return both the result and the tracing information without affecting the existing API.Example Usage:
Proposed Changes in the Rust Wrapper:
In the Rust layer of the driver, we need to modify the query execution to enable tracing and return the tracing details. Here's how the changes might look:
By calling
query.set_tracing(true);
, we enable the collection of tracing information for that specific query. The execution method will then need to be updated to return both the result and the tracing data.Benefits:
Conclusion:
Implementing this feature would greatly enhance the debugging capabilities of the ScyllaDB JavaScript driver without disrupting existing functionalities.
The text was updated successfully, but these errors were encountered: