Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design change] Sub-batch in pixels instead of segments #231

Open
YifanC opened this issue May 17, 2024 · 0 comments
Open

[Design change] Sub-batch in pixels instead of segments #231

YifanC opened this issue May 17, 2024 · 0 comments
Labels
optimization Improvement for performance

Comments

@YifanC
Copy link
Collaborator

YifanC commented May 17, 2024

Paraphrasing Kazu's suggestion here:

Change this sub-batch from segment based to pixel based. Currently we warn users not to enter sub-batch and tune this parameter to try to cover all segments of a batch in one sub-batch. The reason is that the signals on the signals won't be summed up which would cause inaccurate ADC simulation. In theory, you could even get two hits on the same pixel at the same time. If we were keeping the segment sub-batch, at least we should take the readout simulation part out of the sub-batch loop, but it would still be memory heavy, so it defeats the purpose of the sub-batch.

I think it's a good idea to change this sub-batch to be pixel-based (We can do something similar for the light simulation.) We do still need to provide a size of how many segments, but we can then set it to be inclusive trivially (I think...). It should also ease the memory crisis.

I'm interested in this work but cannot commit at the moment. Tag others who might be interested to share the workload @jaafar-chakrani @mjkramer .

@YifanC YifanC added the optimization Improvement for performance label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Improvement for performance
Projects
None yet
Development

No branches or pull requests

1 participant