Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when second player tries to loot a scripted loot chest #177

Closed
Flemse12 opened this issue Nov 26, 2016 · 26 comments
Closed

Error when second player tries to loot a scripted loot chest #177

Flemse12 opened this issue Nov 26, 2016 · 26 comments
Assignees
Milestone

Comments

@Flemse12
Copy link

Flemse12 commented Nov 26, 2016

Hey i get this error whenever my mate tries to loot the same chest as i did, so more players in the dungeon can get loot. Im using 0.15 the latest version available on Spigot, also tried upgrading to latest dev build same thing happens
Also the meesage saying you've been given loot comes up on hes screen but when he acutally leaves the dungeon only i get it

Im working on a large dunegon for a server so it kinda sucks only 1 player can get each loot chest.
Great plugin tho!

26-11-2016 15:57:20 [ERROR] Could not pass event PlayerInteractEvent to DungeonsXL v0.15
26-11-2016 15:57:20 org.bukkit.event.EventException
26-11-2016 15:57:20 at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:486) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at org.bukkit.craftbukkit.v1_10_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:231) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.PlayerInteractManager.a(PlayerInteractManager.java:492) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:877) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.PacketPlayInUseItem.a(SourceFile:55) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.PacketPlayInUseItem.a(SourceFile:11) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_111]
26-11-2016 15:57:20 at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_111]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:692) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:360) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:647) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:551) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 at java.lang.Thread.run(Unknown Source) [?:1.8.0_111]
26-11-2016 15:57:20 Caused by: java.lang.NullPointerException
26-11-2016 15:57:20 at io.github.dre2n.debukkit.DebukkIt.end(DebukkIt.java:74) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.player.DGamePlayer.finishFloor(DGamePlayer.java:774) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.player.DGroup.finishIfMembersFinished(DGroup.java:799) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.player.DGamePlayer.leave(DGamePlayer.java:517) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.player.DGamePlayer.finish(DGamePlayer.java:882) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.player.DGamePlayer.finish(DGamePlayer.java:821) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.sign.EndSign.onPlayerTrigger(EndSign.java:74) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.sign.DSign.onUpdate(DSign.java:180) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.trigger.Trigger.updateDSigns(Trigger.java:114) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.trigger.InteractTrigger.onTrigger(InteractTrigger.java:49) ~[?:?]
26-11-2016 15:57:20 at io.github.dre2n.dungeonsxl.listener.PlayerListener.onInteract(PlayerListener.java:247) ~[?:?]
26-11-2016 15:57:20 at sun.reflect.GeneratedMethodAccessor35.invoke(Unknown Source) ~[?:?]
26-11-2016 15:57:20 at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_111]
26-11-2016 15:57:20 at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_111]
26-11-2016 15:57:20 at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 15:57:20 ... 17 more

@Flemse12
Copy link
Author

Saw someone further down with the same Crashlog mentioning a hotfix, is that available for download?

@Sataniel98 Sataniel98 added the BUG label Nov 26, 2016
@Sataniel98 Sataniel98 added this to the Beta 0.15-HOTFIX milestone Nov 26, 2016
@Sataniel98 Sataniel98 self-assigned this Nov 26, 2016
@Sataniel98
Copy link
Member

Sataniel98 commented Nov 26, 2016

Thank you for the report. I haven't seen this so far so I doubt there's a fix. Shouldn't take long to fix it, though :)

@Flemse12
Copy link
Author

Haha thank you :) Was worried i had to postpone the entire project, ty for quick respond :)

@Sataniel98
Copy link
Member

I couldn't reproduce it, so this is kind of a "blind" try. Please tell me if it works!

http://feuerstern.bplaced.net/repo/io/github/dre2n/dungeonsxl/

@Flemse12
Copy link
Author

Flemse12 commented Nov 26, 2016

Sorta worked, we both got our items now but you can duplicate items by keep doing /dxl rewards and i got all these errors

26-11-2016 21:32:16 [ERROR] Could not pass event PlayerInteractEvent to DungeonsXL v0.15.1-SNAPSHOT-05
26-11-2016 21:32:16 org.bukkit.event.EventException
26-11-2016 21:32:16 at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:486) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at org.bukkit.craftbukkit.v1_10_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:231) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.PlayerInteractManager.a(PlayerInteractManager.java:492) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:877) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.PacketPlayInUseItem.a(SourceFile:55) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.PacketPlayInUseItem.a(SourceFile:11) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:16 at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:692) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:360) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:647) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:551) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:16 at java.lang.Thread.run(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:16 Caused by: java.lang.NullPointerException
26-11-2016 21:32:16 at io.github.dre2n.dungeonsxl.player.DGamePlayer.finish(DGamePlayer.java:873) ~[?:?]
26-11-2016 21:32:16 at io.github.dre2n.dungeonsxl.player.DGamePlayer.finish(DGamePlayer.java:813) ~[?:?]
26-11-2016 21:32:16 at io.github.dre2n.dungeonsxl.sign.EndSign.onPlayerTrigger(EndSign.java:74) ~[?:?]
26-11-2016 21:32:16 at io.github.dre2n.dungeonsxl.sign.DSign.onUpdate(DSign.java:180) ~[?:?]
26-11-2016 21:32:16 at io.github.dre2n.dungeonsxl.trigger.Trigger.updateDSigns(Trigger.java:114) ~[?:?]
26-11-2016 21:32:17 at io.github.dre2n.dungeonsxl.trigger.InteractTrigger.onTrigger(InteractTrigger.java:49) ~[?:?]
26-11-2016 21:32:17 at io.github.dre2n.dungeonsxl.listener.PlayerListener.onInteract(PlayerListener.java:247) ~[?:?]
26-11-2016 21:32:17 at sun.reflect.GeneratedMethodAccessor31.invoke(Unknown Source) ~[?:?]
26-11-2016 21:32:17 at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:17 at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:17 at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:17 ... 17 more
26-11-2016 21:32:32 [INFO] Xovious issued server command: /dxl rewards
26-11-2016 21:32:32 [ERROR] null
26-11-2016 21:32:32 org.bukkit.command.CommandException: Unhandled exception executing command 'dxl' in plugin DungeonsXL v0.15.1-SNAPSHOT-05
26-11-2016 21:32:32 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:140) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at org.bukkit.craftbukkit.v1_10_R1.CraftServer.dispatchCommand(CraftServer.java:625) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.PlayerConnection.handleCommand(PlayerConnection.java:1299) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:1159) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.PacketPlayInChat.a(SourceFile:37) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.PacketPlayInChat.a(SourceFile:9) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:32 at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:692) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:360) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:647) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:551) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 at java.lang.Thread.run(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:32 Caused by: java.util.ConcurrentModificationException
26-11-2016 21:32:32 at java.util.ArrayList$SubList.checkForComodification(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:32 at java.util.ArrayList$SubList.listIterator(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:32 at java.util.AbstractList.listIterator(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:32 at java.util.ArrayList$SubList.iterator(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:32 at java.util.AbstractCollection.contains(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:32 at java.util.AbstractCollection.removeAll(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:32 at io.github.dre2n.dungeonsxl.command.RewardsCommand.onExecute(RewardsCommand.java:60) ~[?:?]
26-11-2016 21:32:32 at io.github.dre2n.dungeonsxl.util.commons.command.BRCommandExecutor.onCommand(BRCommandExecutor.java:71) ~[?:?]
26-11-2016 21:32:32 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:32 ... 15 more
26-11-2016 21:32:34 [INFO] Xovious issued server command: /dxl rewards
26-11-2016 21:32:41 [INFO] nokiaman issued server command: /dxl rewards
26-11-2016 21:32:41 [ERROR] null
26-11-2016 21:32:41 org.bukkit.command.CommandException: Unhandled exception executing command 'dxl' in plugin DungeonsXL v0.15.1-SNAPSHOT-05
26-11-2016 21:32:41 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:140) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at org.bukkit.craftbukkit.v1_10_R1.CraftServer.dispatchCommand(CraftServer.java:625) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.PlayerConnection.handleCommand(PlayerConnection.java:1299) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:1159) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.PacketPlayInChat.a(SourceFile:37) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.PacketPlayInChat.a(SourceFile:9) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:41 at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:692) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:360) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:647) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:551) [craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 at java.lang.Thread.run(Unknown Source) [?:1.8.0_111]
26-11-2016 21:32:41 Caused by: java.util.ConcurrentModificationException
26-11-2016 21:32:41 at java.util.ArrayList$SubList.checkForComodification(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:41 at java.util.ArrayList$SubList.size(Unknown Source) ~[?:1.8.0_111]
26-11-2016 21:32:41 at io.github.dre2n.dungeonsxl.command.RewardsCommand.onExecute(RewardsCommand.java:58) ~[?:?]
26-11-2016 21:32:41 at io.github.dre2n.dungeonsxl.util.commons.command.BRCommandExecutor.onCommand(BRCommandExecutor.java:71) ~[?:?]
26-11-2016 21:32:41 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[craftbukkit-1.10.2.jar:git-Bukkit-67b2424]
26-11-2016 21:32:41 ... 15 more
26-11-2016 21:32:42 [INFO] Xovious issued server command: /dxl rewards

@Sataniel98
Copy link
Member

This should resolve the /dxl rewards bug.

@Flemse12
Copy link
Author

So just dl newet dev build?

@Sataniel98
Copy link
Member

Yes, build 6

@Flemse12
Copy link
Author

Sorry i dont quite follow :) do you want me to add something to the config file?

@Sataniel98
Copy link
Member

No, it should be alright. I haven't fixed everything, yet, but I'm aware of it.

@Flemse12
Copy link
Author

Ah okay thank you :)

@Sataniel98
Copy link
Member

Could you please tell me a bit more about the circumstances of the end sign bug (the one that still occurs in the latest build)? Like:

  • How many groups are in the dungeon?
  • How many players are in the groups?
  • How do you let the players setup their group? (e.g. group signs)
  • Does it happen in any dungeon or just in a few ones?
  • How exactly does the bug influence the game (besides causing a console stacktrace)?

@Flemse12
Copy link
Author

Flemse12 commented Nov 29, 2016

  • Only tested with 1 Group in play but, 3 Groups are able to play at once
  • Tested with two players
  • Groups signs using Ready Default sing aswell
  • Happens in all Dungeons
  • The players get ther rewards when leaving, but will have to do /dxl rewards to get rewards other player looted.

@Sataniel98
Copy link
Member

Not entirely sure why this happens at the moment.

@Flemse12
Copy link
Author

Has any Progress been made on this?

@Sataniel98
Copy link
Member

Sataniel98 commented Dec 13, 2016

Not yet. Sataniel is kind of an adult, Sataniel got shit to do ¯\(ツ)

@Flemse12
Copy link
Author

Hehe i understand fully, take your time :)
Still seems like the only game breaking bug i ever encountered :)

@Sataniel98
Copy link
Member

Glad to hear that, I'm trying to make DXL ready for a production environment at the moment. Please tell me if you notice anything else, even if it's just a minor thing like spelling mistakes or stacktraces without any noticeable impact.

@Sataniel98
Copy link
Member

Finally found an empty evening & the bug. I really hope that this fix does it for you, worked well when I tested it but it might break some other things so I'll test a bit more before I release it officially. The release candidate is available at the dev build server.

@Flemse12
Copy link
Author

Tested on 0.15.3 wich i suppose is the build your talking about. And it still is causing the crash log, items where not distriputed probely, i got 3 items and my friends got 1, and still had to use ,/dxl rewards even tho my inv was almost empty.

@Sataniel98
Copy link
Member

My bad, I uploaded the build but forgot to add it to the list.

Direct download:
http://feuerstern.bplaced.net/repo/io/github/dre2n/dungeonsxl/0.15.3-RC-01/dungeonsxl-0.15.3-RC-01.jar

@Flemse12
Copy link
Author

Good News, the crash log is gone, tho there is still a few problems.

  • When Looting one chest you get the loot from all the chest in the Dungeon.
  • You still have to do that extra /dxl rewards when leaving (not sure if intended or not but seems wierd)
  • When trying to enter a dungeon through a portal on this build it gives the meesage "This Dungeon dosent Exist)

@Sataniel98
Copy link
Member

Thank you. I'm sure I'll find time to fix this in the next days or at least right after Christmas.

@Flemse12
Copy link
Author

Flemse12 commented Dec 21, 2016

Also some of the items for example the Token i made, is an invalid image file so its just a giant purple/black box.
Current Loot table
0:
item:
==: io.github.dre2n.caliburn.item.UniversalItemStack
type: "CUSTOM_DEFAULT"
material: "IRON_SWORD"
durability: 35
name: "&4Bad Sword"
amount: 1
lores:
- "&4This is the first line."
- "&6This is the second line."
enchantments:
"PROTECTION_ENVIRONMENTAL": 4
"THORNS": 1
attributes:
name:
type: "GENERIC_ATTACK_DAMAGE"
slots:
- "MAIN_HAND"
- "HEAD"
operation: "ADD_NUMBER"
amount: 8.5
chance: 100
1:
item:
==: io.github.dre2n.caliburn.item.UniversalItemStack
type: "CUSTOM_DEFAULT"
material: "gold_nugget"
durability: 35
name: "&4Token"
amount: 1
lores:
- "&4This is the first line."
- "&6This is the second line."
enchantments:
attributes:
name:
type: "GENERIC_ATTACK_DAMAGE"
slots:
- "MAIN_HAND"
- "HEAD"
operation: "ADD_NUMBER"
amount: 8.5
chance: 100

@Sataniel98
Copy link
Member

Minecraft does not know gold nuggets with durability 35, so it uses a placeholder texture (since 1.8 or 1.9 AFAIK). I'm not an expert, but it should still be possible to make custom MCPatcher CIT or Vanilla sprites for these items with a resource pack.

@Sataniel98
Copy link
Member

I couldn't reproduce the first two problems. However, I fixed the portal bug in 0.15.3. Merry Christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants