Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests on main are broken #177

Closed
jmsmkn opened this issue Jan 14, 2025 · 0 comments · Fixed by #178
Closed

Tests on main are broken #177

jmsmkn opened this issue Jan 14, 2025 · 0 comments · Fixed by #178
Assignees
@chrisvanrun

Comments

@jmsmkn
Copy link
Member

jmsmkn commented Jan 14, 2025

Likely due to the change in the ordering of the CIVs introduced in comic/grand-challenge.org#3768 and a different order being assumed in the tests. An ordering shouldn't be assumed in the tests, the returned CIVS should be filtered for what is trying to be asserted.
@chrisvanrun chrisvanrun self-assigned this Jan 14, 2025
@chrisvanrun chrisvanrun linked a pull request Jan 16, 2025 that will close this issue
Fix tests on main are broken #178
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisvanrun chrisvanrun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests on main are broken DIAGNijmegen/rse-gcapi
2 participants
@chrisvanrun @jmsmkn