-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not use dbs.task_api, use dbs.tasks directly #3
Comments
I disagree.
Since we are still in proof-of-concept state, I don't think this issue is really important. It's just implementation. Once we leave PoC state, we can discuss it and agree on something. |
It is not "on server" it is "in dbs" - worker, server, commandline interface, they are all part of the same dbs. There is no celery stuff, there is just dbs stuff. No need to have python api between left and right hand. Nohting to hide.
The current implementation of callbacks is bad designed and if we don't throw it away now, we will do it in the future. Relying on theese callbacks is pure waste of time.
No, we should discuss now. As I said before, building something (including PoC) on top of something what is already known to be bad designed, is waste of time. |
So... we'll have django code in celery stuff, is that right? Testing that thing will be a real bliss -- I'm going to need server with database just to smoke test some tasks. Until now, worker could run by itself easily without need of running server. |
There is no django code, nor celery stuff. There is even no server and no worker (and fortunately no smoke yet).
You may still simply test any task without running server. Task is yet another function, which you may call directly or asynchronously from view, from command, or from any application written in python. |
There is no reason for this layer.
The tasks in dbs.tasks should be complex enough to be called directly from dbs.api.views or dbs.management.commands.
The text was updated successfully, but these errors were encountered: