Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config format standardization #71

Closed
lladdy opened this issue Jul 29, 2018 · 4 comments · Fixed by #74
Closed

Config format standardization #71

lladdy opened this issue Jul 29, 2018 · 4 comments · Fixed by #74

Comments

@lladdy
Copy link
Contributor

lladdy commented Jul 29, 2018

Currently we have multiple configs that use differing formats.
I suggest we standardize any configs to all use the same format to allow the use of the same tools/libraries for all configs.
Json makes sense to me at this point in time.

I'm happy to take on this task - just want to make sure people are in support of it if I do.

@lladdy lladdy changed the title Config standardization Config format standardization Jul 29, 2018
@alkurbatov
Copy link
Contributor

So, which format is preferred?

@lladdy
Copy link
Contributor Author

lladdy commented Jul 30, 2018

Probably Json, if that's what you mean: The change would be minimal because we already have rapidJson integrated.

@alkurbatov
Copy link
Contributor

The only issue with json is that it is not detected by default on Windows, see:
davechurchill/commandcenter#18

It could be also .ini (might be recognized on Windows by default) or .yaml which is very popular now.

@lladdy
Copy link
Contributor Author

lladdy commented Jul 30, 2018

The only issue with json is that it is not detected by default on Windows, see:
davechurchill/commandcenter#18

That's a fair enough reason.

It could be also .ini (might be recognized on Windows by default) or .yaml which is very popular now.

.ini is recognized on windows. Neither yml nor yaml are.
I would be eager to consider YAML as it seems a suitable candidate for configs in general, but my intention here is to merely standardize the formats first in order to simplify working with the configs (one file format, one parser, etc).
Maybe this is too many changes and we should first decide the final format?

If we moved the LadderManagers.conf file to json, my vote would be for maintaining the json extension for consistency's sake.
However, if we did move to a txt extension (or another recognized by Windows), then we should probably do the same for LadderBots.json as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants