From 651746d283e189cb02f20b7b0c207742d67fadfb Mon Sep 17 00:00:00 2001
From: Andrew Hemming <andrew.hemming@redrockconsulting.co.uk>
Date: Wed, 27 Mar 2024 15:49:46 +0000
Subject: [PATCH] Fix variable

---
 .../create_tester_user_task.tf                         |  2 +-
 modules/create-rds-postgres-tester/main.tf             |  2 +-
 modules/create-rds-postgres-tester/variables.tf        | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/create-rds-postgres-tester/create_tester_user_task.tf b/modules/create-rds-postgres-tester/create_tester_user_task.tf
index bf1b18f2..a08600de 100644
--- a/modules/create-rds-postgres-tester/create_tester_user_task.tf
+++ b/modules/create-rds-postgres-tester/create_tester_user_task.tf
@@ -19,7 +19,7 @@ module "create_tester_user_task" {
       ]
       port = null
       secret_environment_variables = [
-        { "name" : "DB_CONNECTION_URL", "valueFrom" : var.target_db_connection_url_ssm_param_arn }
+        { "name" : "DB_CONNECTION_URL", "valueFrom" : var.db_connection_url_ssm_param_arn }
       ]
     }
   }
diff --git a/modules/create-rds-postgres-tester/main.tf b/modules/create-rds-postgres-tester/main.tf
index 265e28ff..ecee6d93 100644
--- a/modules/create-rds-postgres-tester/main.tf
+++ b/modules/create-rds-postgres-tester/main.tf
@@ -27,7 +27,7 @@ resource "aws_sfn_state_machine" "create-tester-user" {
               "Environment": [
                 {
                   "Name": "DB_CONNECTION_URL",
-                  "Value": "${var.target_db_connection_url_ssm_param_arn}"
+                  "Value": "${var.db_connection_url_ssm_param_arn}"
                 }
               ]
             }
diff --git a/modules/create-rds-postgres-tester/variables.tf b/modules/create-rds-postgres-tester/variables.tf
index 14ebe751..217ea9ac 100644
--- a/modules/create-rds-postgres-tester/variables.tf
+++ b/modules/create-rds-postgres-tester/variables.tf
@@ -31,6 +31,11 @@ variable "db_clients_security_group_id" {
   description = "ID of the security group that allows access to the RDS instance"
 }
 
+variable "db_connection_url_ssm_param_arn" {
+  type        = string
+  description = "ARN of SSM param which contains the connection URL for the Postgres database"
+}
+
 variable "db_name" {
   type        = string
   description = "Database name"
@@ -73,11 +78,6 @@ variable "subnet_id" {
   description = "ID of the subnet in which to run the extract/load ECS tasks and also in which to present the EFS mount point"
 }
 
-variable "target_db_connection_url_ssm_param_arn" {
-  type        = string
-  description = "ARN of SSM param which contains the connection URL for the target Postgres database"
-}
-
 variable "vpc_id" {
   type        = string
   description = "ID of the VPC into which to deploy the resources"