Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace/configuration for .emmyrc.json #6

Open
Saghen opened this issue Jan 22, 2025 · 3 comments
Open

workspace/configuration for .emmyrc.json #6

Saghen opened this issue Jan 22, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@Saghen
Copy link
Contributor

Saghen commented Jan 22, 2025

Lazydev.nvim uses the workspace/configuration call to set the lua-language-server configuration at runtime. This allows it to add libraries to the language server only as necessary. Would it be possible for emmylua-analyzer to support this call to get a subset of the .emmyrc.json from the client? And support making the call to neovim if available? (currently VSCode only)

As far as I can tell, it also makes use of the DidConfigurationChange event to tell the LSP to refetch the configuration.

@Saghen Saghen changed the title workspace/configuration for .emmyrc.json workspace/configuration for .emmyrc.json Jan 22, 2025
@CppCXY CppCXY added the enhancement New feature or request label Jan 23, 2025
@CppCXY
Copy link
Owner

CppCXY commented Jan 23, 2025

see: b4ec3e1

I tried to support the relevant configuration, but I don't have a test environment. Additionally, it is generally not common to actively synchronize the configuration to the language server from the client. I see that this is the case in VSCode.
Image

@folke
Copy link

folke commented Jan 23, 2025

for lazydev, I'd only need the functionality where the LSP pulls the configuration.

I trigger the pull with "workspace/didChangeConfiguration",
and respond with the new config when the LSP sends a "workspace/configuration"

Is this something you could support? (or already support?)

@CppCXY
Copy link
Owner

CppCXY commented Jan 24, 2025

for lazydev, I'd only need the functionality where the LSP pulls the configuration.

I trigger the pull with "workspace/didChangeConfiguration", and respond with the new config when the LSP sends a "workspace/configuration"

Is this something you could support? (or already support?)

I try support the config: 0171b9c
If you think it's okay, I will release the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants