Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Cotton Crash #35

Open
Diamondman121314 opened this issue Jul 24, 2019 · 6 comments
Open

Possible Cotton Crash #35

Diamondman121314 opened this issue Jul 24, 2019 · 6 comments
Labels
good first issue Good for newcomers

Comments

@Diamondman121314
Copy link

Diamondman121314 commented Jul 24, 2019

Describe the bug
It seems my client has been crashing when it seemingly looks like I pass a certain amount of mods. I've been suggested to report this here. Now in the crash report, it shows both Inca and Cotton Resources, but seems to also include Cotton, as obviously being a dependency. I'm not sure which it would be in this case between the two. I do have about 95% of all working mods for Fabric which is somewhere around 300-350 so I'm not sure if this would be incompatibility between mods somewhere. I talked a lot about this in the #player-general channel of the Fabric Discord.

Crash Log
A lot of my mods with names starting with L and after are disabled because of it seeming to be limited to a certain amount of mods.

To Reproduce
Steps to reproduce the behavior:

  1. Load the client with a decent number of mods, at least 150 from what I can tell.
  2. See error

Expected behavior Optional
Client to load without any errors and to not crash.

Screenshots Optional
N/A

Version of the (please complete the following information):

  • Cotton 1.0.0-rc.2
  • Fabric API 0.3.0+build.200
  • Minecraft 1.14.4

Additional context Optional
If you need any more information or more testing to be done, I can do that.

@Diamondman121314 Diamondman121314 added the bug Something isn't working label Jul 24, 2019
@falkreon falkreon added good first issue Good for newcomers and removed bug Something isn't working labels Jul 24, 2019
@falkreon
Copy link
Member

falkreon commented Jul 24, 2019

Looks like a bad Cotton Datapack + Cotton Logger interaction, happening entirely within Cotton. This should help us a lot in tracking it down, thanks

@falkreon
Copy link
Member

On second thought, peeking at the Inca source, it looks like it's built for Cotton 0.4.8 (which 1.0.0 contains breaking changes from). Does it crash without Inca?

@Diamondman121314
Copy link
Author

It does still crash without Inca. It's the same error, just without the entire Inca section. If you need the crash report for that, I'll provide it.

@falkreon
Copy link
Member

Nope. Just knocking out alternate explanations. The log you provided should be enough.

@Diamondman121314
Copy link
Author

So from I can see, the recent update to Cotton Resources fixed the issue for that, but the Inca one is still a problem, though I realize it will most likely have to be fixed on Inca's side.

@falkreon
Copy link
Member

C-R is now immune, yes, but the Cotton issue remains, I'll leave this open till we can track it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants