Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ip6tables related rules #11054

Open
marcusburghardt opened this issue Sep 7, 2023 · 2 comments
Open

Review ip6tables related rules #11054

marcusburghardt opened this issue Sep 7, 2023 · 2 comments
Assignees
Labels
CPE-AL CPE Applicability Language Update Rule Issues or pull requests related to Rules updates.

Comments

@marcusburghardt
Copy link
Member

Description of problem:

While investigating the #10896 it was noticed some issues with ip6tables related rules:

Here are some improvements opportunities:

  • These rules should not be executed if IPv6 is not enabled in the system.
  • their platforms should include ipv6[enabled]
  • These rules should only be applicable if:
    • iptables package is present;
    • ntfables and firewalld services are not enabled;
    • ufw package is not present;
    • So, probably this should be the correct definition of platform:
      • package[iptables] and not package[ufw] and service_disabled[firewalld] and service_disabled[nftables]
  • They don't have an OVAL but the one could be created to check the /etc/sysconfig/ip6tables file
    • The OVAL can't check run-time, but it should be fine to ensure the expected configuration.
  • There is a SCE script for Ubuntu.
    • It could be renamed to shared.sh
    • and the header updated to platform = multi_platform_ubuntu

SCAP Security Guide Version:

0.1.69

Operating System Version:

All products where ip6tables is available.

Additional Information/Debugging Steps:

@Mab879
Copy link
Member

Mab879 commented Jan 16, 2025

@teacup-on-rockingchair Is this valid or can we close it?

@teacup-on-rockingchair
Copy link
Contributor

@teacup-on-rockingchair Is this valid or can we close it?

Well the final solution from my perspective is still up for review see #11818

This PR was a bit unlucky 😎 , and thought it got some initial positive review, there was I guess not enough time to pass the process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPE-AL CPE Applicability Language Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

No branches or pull requests

3 participants