Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Refactor reusable components #133

Merged
merged 28 commits into from
May 26, 2020
Merged

WIP - Refactor reusable components #133

merged 28 commits into from
May 26, 2020

Conversation

mxnyee
Copy link
Contributor

@mxnyee mxnyee commented Mar 30, 2020

Will need to be updated then merged after other branches get merged.
All functionality should be the same as before.

  • cleaned all components except for ./drawer and ./timer for consistency, code style, etc
  • switched to validate.js for form validations in Input component

@mxnyee
Copy link
Contributor Author

mxnyee commented May 19, 2020

new changes:

  • Fix signup functionality (email validation was not completely removed)
  • Prevent double tapping buttons from pushing screens twice onto navigation stack
  • Update Timer fonts to match client spec
  • Add loadingText prop to Button to display when button has been disabled
  • General cleaning

image

@Asiapenguin Asiapenguin merged commit e8ab447 into master May 26, 2020
@mxnyee mxnyee linked an issue Jun 14, 2020 that may be closed by this pull request
[UHN-MA-66] Refactor components #132
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asiapenguin Asiapenguin Asiapenguin approved these changes

@Wennxn Wennxn Awaiting requested review from Wennxn

@cadrianxyz cadrianxyz Awaiting requested review from cadrianxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UHN-MA-66] Refactor components
2 participants
@mxnyee @Asiapenguin