Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UHN-BS-35] Help request sends to unavailable responders #72

Open
mxnyee opened this issue Mar 15, 2020 · 1 comment
Open

[UHN-BS-35] Help request sends to unavailable responders #72

mxnyee opened this issue Mar 15, 2020 · 1 comment
Labels
bug Something isn't working endpoint

Comments

@mxnyee
Copy link
Contributor

mxnyee commented Mar 15, 2020

Was this always a problem or am I missing something?

To reproduce:

  • make sure user A is a responder for user B
  • log in as user A and turn off the Naloxone availability switch
  • make a help request for user B
  • result: user A gets a help request notification
  • expected result: A should not get a notification because he doesn't have Naloxone

In help_request.js:71, we're adding all of the user's responders to the help request. But we should filter out the responders who aren't available, right?

Same in notification.service.js:11. We only want the push tokens of responders who are available. Isn't this what the userResponders field in the help_request is for?

@mxnyee mxnyee added bug Something isn't working endpoint labels Mar 15, 2020
@Asiapenguin
Copy link
Contributor

I agree with the changes highlighted in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working endpoint
Projects
None yet
Development

No branches or pull requests

2 participants