Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tyvik/geopuzzle repo #201

Merged
merged 3 commits into from
Oct 9, 2021
Merged

Add tyvik/geopuzzle repo #201

merged 3 commits into from
Oct 9, 2021

Conversation

TyVik
Copy link
Contributor

@TyVik TyVik commented Oct 7, 2021

I'm going to add more details later for "Contributing" block.

@netlify
Copy link

netlify bot commented Oct 7, 2021 •
edited
Loading

✔️ Deploy Preview for oss-port ready!
Built without sensitive environment variables

🔨 Explore the source changes: d3bf568

🔍 Inspect the deploy log: https://app.netlify.com/sites/oss-port/deploys/61606fff2cb2430007cacbbd

😎 Browse the preview: https://deploy-preview-201--oss-port.netlify.app

hola-soy-milk
hola-soy-milk suggested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@hola-soy-milk hola-soy-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Added one change request, please!

@hola-soy-milk hola-soy-milk added the awaiting response Waiting for contributor to respond to maintainers' comments or update PR label Oct 7, 2021
@TyVik
Copy link
Contributor Author

TyVik commented Oct 8, 2021 •
edited
Loading

I've updated "Contributing" section.
Also, I added some featured maps.

Yep, it fails. Take a look...

@TyVik
Copy link
Contributor Author

TyVik commented Oct 8, 2021

I fixed but is it possible to keep more than one feature map?

@TyVik TyVik requested a review from hola-soy-milk October 9, 2021 05:23
@hola-soy-milk
Copy link
Contributor

Thank you so much, this looks fantastic!

The request is really interesting too! I hadn't considered this yet. I'll make an issue of this. In the meantime, please feel free to add the links to other maps in your overview section.

Once you give me the green light I'll happily merge.

Thanks in advance!

@TyVik
Copy link
Contributor Author

TyVik commented Oct 9, 2021

Could you please merge this PR?

I've finished it for now and I'm waiting for #212 :) No rush of course - I subscribed on this issue and will receive a reminder when the ticket will be closed.

@hola-soy-milk
Copy link
Contributor

On it. Thanks again and welcome to Port! 🚢

@hola-soy-milk hola-soy-milk merged commit d8cd838 into Codesee-io:main Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hola-soy-milk hola-soy-milk hola-soy-milk approved these changes

@NJalal7 NJalal7 Awaiting requested review from NJalal7

@shaneakr shaneakr Awaiting requested review from shaneakr

Assignees
No one assigned
Labels
awaiting response Waiting for contributor to respond to maintainers' comments or update PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TyVik @hola-soy-milk