Bootstrap update reference #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialuogao
reviewed
Oct 16, 2020
views/index.ejs
Outdated
| @@ -40,7 +40,7 @@ | |||
| <a class="btn primary-button" href="/contact">Contact Us</a> | |||
| </div> | |||
| <div class="index-sponsor-container"> | |||
| <h2 class="index-sponsor-text row center">Our Sponsors</h2> | |||
| <h2 class="index-sponsor-text row mx-auto">Our Sponsors</h2> | |||
There was a problem hiding this comment.
seems like you have removed the center class?
There was a problem hiding this comment.
center class is located in style.css with .center { text-align: center; } and it is not a bootstrap class
jialuogao
requested changes
Oct 16, 2020
views/template/head.ejs
Outdated
| <link rel="stylesheet" type="text/css" href="/css/jquery-editable-select.min.css"/> | ||
| <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" /> | ||
| <!-- <link rel="stylesheet" type="text/css" href="/css/bootstrap.min.css"> --> | ||
| <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.5.2/css/bootstrap.min.css" integrity="sha384-JcKb8q3iqJ61gNV9KGb8thSsNjpSL0n8PARn9HuZOnIxN0hoP+VmmDGMN5t9UJ0Z" crossorigin="anonymous"> |
There was a problem hiding this comment.
I thought you have downloaded the bootstrap on local, please then use the local reference
views/template/head.ejs
Outdated
| <!-- <script src="/js/bootstrap.min.js"></script> --> | ||
| <script src="https://code.jquery.com/jquery-3.5.1.min.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/umd/popper.min.js" integrity="sha384-9/reFTGAW83EW2RDu2S0VKaIzap3H66lZH81PoYlFhbGU+6BZp6G7niu735Sk7lN" crossorigin="anonymous"></script> | ||
| <script src="https://stackpath.bootstrapcdn.com/bootstrap/4.5.2/js/bootstrap.min.js" integrity="sha384-B4gt1jrGC7Jh4AgTPSdUtOBvfO8shuf57BaghqFfPlYxofvL8/KUEfYiJOMMV+rV" crossorigin="anonymous"></script> |
There was a problem hiding this comment.
Same as above use the local link
views/template/head.ejs
Outdated
| <script src="/js/jquery-3.2.1.min.js"></script> | ||
| <script src="/js/jquery-ui.js"></script> | ||
| <script src="/js/bootstrap.min.js"></script> | ||
| <!-- <script src="/js/bootstrap.min.js"></script> --> | ||
| <script src="https://code.jquery.com/jquery-3.5.1.min.js"></script> |
There was a problem hiding this comment.
If you have time please also download jquery 3.5.1 replace the local 3.2.1 on line 20
views/template/head.ejs
Outdated
| <script src="/js/bootstrap.min.js"></script> | ||
| <!-- <script src="/js/bootstrap.min.js"></script> --> | ||
| <script src="https://code.jquery.com/jquery-3.5.1.min.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/umd/popper.min.js" integrity="sha384-9/reFTGAW83EW2RDu2S0VKaIzap3H66lZH81PoYlFhbGU+6BZp6G7niu735Sk7lN" crossorigin="anonymous"></script> |
views/index.ejs
Outdated
| @@ -40,7 +40,7 @@ | |||
| <a class="btn primary-button" href="/contact">Contact Us</a> | |||
| </div> | |||
| <div class="index-sponsor-container"> | |||
| <h2 class="index-sponsor-text row center">Our Sponsors</h2> | |||
| <h2 class="index-sponsor-text row mx-auto">Our Sponsors</h2> | |||
There was a problem hiding this comment.
center class is located in style.css with .center { text-align: center; } and it is not a bootstrap class
|
|
Two small issues left to deal with: 1. Navbar hamburger icon collapses to the right 2. Password invisible
Aligned the cfg icon and navbar items
…dit my project fixed the styles of Create event & Edit event page & Create new project Page& Edit my project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My updates:
[views/event/index.ejs]
Line 42-45 -> 42
Line 52-62 -> 50-67
Line 67 -> 71
[views/index.ejs]
Line 43: Center is no longer exist so replaced with mx-auto
[head.ejs]
Line 13-17 -> 13-19: Reference changed
Line 20 -> 22-25: Reference changed
[nav.ejs]
Line 11: navbar-default is no longer exist so change to the new Line 11
Line 16: toggle -> toggler
Line 27-32:
Line 34-35: navbar-right is replaced
Line 37-38: padding-top changed
[login.ejs]
Line 56-58
Line 60-62 -> 63-65
Class “input-group-addon" is no longer exist, so replaced with Class "input-group-prepend"
[signup.ejs]
Line 67&68 ->67
Line 71 -> 73
Line 75&76-> 79
Line 79 -> 85
Class “input-group-addon" is no longer exist, so replaced with Class "input-group-prepend"
[forget-password.ejs]
Line 56-57->56-59
Class “input-group-addon" is no longer exist, so replaced with Class "input-group-prepend"