Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

LocalWrapper deletion possible #218

Open
einrobin opened this issue Nov 27, 2019 · 3 comments
Open

LocalWrapper deletion possible #218

einrobin opened this issue Nov 27, 2019 · 3 comments
Labels
bug Something isn't working done This issue has been dealt with and will be closed with the next pull request into master

Comments

@einrobin
Copy link
Contributor

I think the local wrapper shouldn't be able to be deleted using "delete wrapper NAME", this causes problems like this https://pastes.gq/vAlpyAEgC9 when you restart the local wrapper.

To reproduce this, just start the Master using the localwrapper start file and then delete the wrapper by typing "delete wrapper Wrapper-1" in the console, now restart the master and you should see the errors from above.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.56. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Nov 27, 2019
@GiantTreeLP
Copy link
Member

This is a tough one but I'm sure I can fix that quickly

@GiantTreeLP
Copy link
Member

Fixed

GiantTreeLP added a commit that referenced this issue Nov 27, 2019
@GiantTreeLP
Make sure that a user can't delete the local wrapper
7d740f1 
Fixes #218
@GiantTreeLP GiantTreeLP added the done This issue has been dealt with and will be closed with the next pull request into master label Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working done This issue has been dealt with and will be closed with the next pull request into master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiantTreeLP @einrobin