Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Fixes failing Test in Windows when attempting to locate files with reserved characters in the file path #2115

Merged
merged 1 commit into from
Jan 25, 2025
Merged

PR Fixes failing Test in Windows when attempting to locate files with reserved characters in the file path #2115

merged 1 commit into from
Jan 25, 2025

Conversation

MaheshMadushan
Copy link
Contributor

@MaheshMadushan MaheshMadushan commented Jan 25, 2025 •
edited
Loading

Summary

Throws an exception when try to find a file with reserved character in the file path on Windows OS
Test failure in Windows when attempting to locate files with reserved characters in the file path.
{C3380B60-8E88-4027-8F1E-E1B745387316}

Closes Test failure in Windows when attempting to locate files with reserved characters in the file path.

Checklist

Delete items not relevant to your PR:

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MaheshMadushan MaheshMadushan force-pushed the Windows_failing_test_fix branch 3 times, most recently from 61f94c8 to cd4f22a Compare January 25, 2025 05:45
@MaheshMadushan MaheshMadushan force-pushed the Windows_failing_test_fix branch from cd4f22a to 8ce70aa Compare January 25, 2025 05:49
@MaheshMadushan MaheshMadushan changed the title Fix a failing test in windows because of reserved characters in file … Fix a failing Test in Windows when attempting to locate files with reserved characters in the file path Jan 25, 2025
@MaheshMadushan MaheshMadushan changed the title Fix a failing Test in Windows when attempting to locate files with reserved characters in the file path PR Fixes failing Test in Windows when attempting to locate files with reserved characters in the file path Jan 25, 2025
@chernser
Copy link
Contributor

Good day, @MaheshMadushan !
My respect for this contribution!

@MaheshMadushan
Copy link
Contributor Author

Hello @chernser , Are these CI failures anticipated? Shall i look into it?

@chernser
Copy link
Contributor

@MaheshMadushan no worries - just cloud tests.

@chernser chernser merged commit fdf6430 into ClickHouse:main Jan 25, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure in Windows when attempting to locate files with reserved characters in the file path.
3 participants
@MaheshMadushan @CLAassistant @chernser