Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for large metadata #2103

Open
mshustov opened this issue Jan 22, 2025 · 3 comments
Open

Add tests for large metadata #2103

mshustov opened this issue Jan 22, 2025 · 3 comments
Labels
jdbc-v2 jdbc-v2 issues test

Comments

@mshustov
Copy link
Member

to verify the client and JDBC driver handle cases with a couple of thousand tables. see metabase/metabase#52496

@mshustov mshustov added the test label Jan 22, 2025
@chernser chernser added the jdbc-v2 jdbc-v2 issues label Jan 22, 2025
@chernser
Copy link
Contributor

I'm a bit confused. Original issue says:
"As far as I understand, Metabase finds some table during the sync-tables task and can't find it during the sync-fields."
Ok - two phase sync.
Then to reproduce the issue:
"When the sync-tables task is completed, delete the new table as soon as possible"

  • it looks like a Metabase issue. Driver returns information from database and has no schema cache. Metabase can implement it.
  • what should we do with removed table?
  • as I can see whole sync is failed, what make sense - do not change schema while schema sync. But again - error handling is on Metabase side.

@mshustov
Copy link
Member Author

The root cause for this particular problem on the Metabase-side, my point was that we don't have some sort of a stress testing for the driver

@chernser
Copy link
Contributor

@mshustov I agree that we need some stress tests.
But the issue with metabase is a different - they are affected by temp. tables or views. User just want metabase to ignore fact they are missing and continue sync. process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jdbc-v2 jdbc-v2 issues test
Projects
None yet
Development

No branches or pull requests

2 participants