Fatal Error: PHP 7.4 Curly brackets deprecated. Plugin doesn't Install

[bahiirwa]

Describe the bug
…curly brace syntax

PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it.

PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

See https://core.trac.wordpress.org/ticket/47751.

I have the same issue with
includes/wc-formatting-functions.phpon line 776-778

To Reproduce
Steps to reproduce the behavior:

1. Use a server with PHP 7.4
2. Turn on WP_DEBUG to true
3. Install CC
4. Big screen error shows up. Plugin not Installed.

Screenshots

Expected behavior

• Plugin should install.
• No fatal error

ClassicPress Environment
N/A

[timbocode]

Looks like a fairly straightforward change.

$rgb['R'] = hexdec( $color{0} . $color{1} );
$rgb['G'] = hexdec( $color{2} . $color{3} );
$rgb['B'] = hexdec( $color{4} . $color{5} );

Unlikely to be a breaking change but will need manually testing and any automatic tests updating.

[bahiirwa]

PR #225 Submitted.
Travis CI passing. No breaking changes.
Tests already exist (test_wc_rgb_from_hex) in tests/unit-tests/formatting/functions.php

[timbocode]

OK, that looks good then. 👍

[bahiirwa]

This issue has a merged PR #225. Needs closing @timbocode