Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is pharmaPCSAFT model in conflict with EoSSuperancillaries.jl? #337

Closed
B-LIE opened this issue Feb 3, 2025 · 4 comments
Closed

Is pharmaPCSAFT model in conflict with EoSSuperancillaries.jl? #337

B-LIE opened this issue Feb 3, 2025 · 4 comments
Labels
bug Something isn't working flash Issues related to flash calculations

Comments

@B-LIE
Copy link

B-LIE commented Feb 3, 2025

Consider the following case of doing VT flash with model pharmaPCSAFT...

Image

If I add the EoSSuperancillaries.jl package, pharmaPCSAFT crashes [don't look at the time it takes for a crash the second time -- if I restart the notebook in between, it take some 2 minutes or something on my laptop before the crash]:

Image

What is going on? The other EoS:es I have tested (PCSAFT, PR, etc., etc.) work when I add EoSSuperancillaries.jl.
@longemen3000
Copy link
Member

Ohh, let me see what is happening

@longemen3000
Copy link
Member

smaller reproducer:

saturation_pressure(pharmaPCSAFT("oxygen"),70+273.15)

longemen3000 added a commit that referenced this issue Feb 3, 2025
@longemen3000
fix error with EoSSuperancilaries and pharmaPCSAFT("oxygen") (#337)
c51c156
@longemen3000
Copy link
Member

The fix is already in the latest master. If the tests are ok, a new release can be done.

@longemen3000 longemen3000 added bug Something isn't working flash Issues related to flash calculations labels Feb 3, 2025
@longemen3000
Copy link
Member

closed in v0.6.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flash Issues related to flash calculations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longemen3000 @B-LIE