Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactSegment Bao assumes contact_id and parent_id and the Disable api does not always honor this. #9

Open
kainuk opened this issue Aug 12, 2019 · 1 comment

Comments

@kainuk
Copy link
Contributor

kainuk commented Aug 12, 2019

The ContactSegment Bao tries to do a good job when deactivating a parent segment. It assumes however that contact_id, and the segmend_id are supplied as paremeters. See line 198,199.

  $deactiveChildContactSegmentParams[1] = array($params['contact_id'], 'Integer');
  $deactiveChildContactSegmentParams[2] = array($params['segment_id'], 'Integer');

However the ContactSegment Disable job does not always do this, so it fails with an exception. (Documented in https://smit.pum.nl/issues/3851)

Solution, add the parameters to the disable api.

@kainuk
Copy link
Contributor Author

kainuk commented Aug 12, 2019

Fix in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant