Add pkgcheck to repository #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This is needed to pass the test coverage check of pkgcheck
fnattino
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Nice! The repository is getting more and more complete. Two things that I think should be added as well are:
- a CITATION.cff file (see e.g. here)
- a GitHub action running a code linter, it is always nice to get static code analysis and check the code against code style (I see you mentioned this in the CONTRIBUTING file). Maybe
lintr? I see that a GitHub action can be easily created withusethis.
I guess these could also be addressed in new PRs.
Yes, let's address these in separate PRs as they are not formally part of pkgcheck. |
This was referenced Jun 28, 2024
Closed
Closed
Merged
fnattino
reviewed
Jun 28, 2024
I am not sure, but in any case I would explore this error in the context of the (now) more complete main branch. I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added
pkgcheckwhich needs to be passed if we want to submit the package for review on rOpenSci, as indicated in the proposal.