Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address contains appartment number returned reject response #36

Open
thopah opened this issue Apr 2, 2020 · 1 comment
Open

address contains appartment number returned reject response #36

thopah opened this issue Apr 2, 2020 · 1 comment

Comments

@thopah
Copy link

thopah commented Apr 2, 2020

it might be good to enhance the "Single-field Search" Geoclient parser to ignore/remove the user input address with apartment number or floor number. For example, a real live example of valid address "37 WEST 26TH STREET - 6TH FLOOR, 10010" will return "REJECTED" status.

@mlipper
Copy link
Member

mlipper commented Apr 24, 2020

Hi @thopah

Apologies for the late reply. Things here in NYC have been hectic recently :-| as I'm sure you know.

I really like this idea and it shouldn't be too difficult to implement. Assuming it hasn't gathered too much dust, the geoclient-parser subproject was pretty self-contained. Way back I had written a crude but effective, configuration-based, regex-expression test class for the purpose of validating new parser/lexer functionality.

I'll try to take a closer look in the next few days, and if it's easy, I'll add this feature. However, if it's more involved, I won't be able to work on it in the near future. If you're a developer and feel like submitting a PR, I'll do my best to work with you if you have questions.

Thanks,
Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants