release-4.0.0 (HDS-2069) Select component (part I) #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikoHelle
force-pushed
the
hds-2069-select-part-i
branch
2 times, most recently
from
f0b0722 to
bb2e048
Compare
laurakarhu
approved these changes
Mar 25, 2024
packages/react/src/components/select/components/selectedOptions/ButtonWithSelectedOptions.tsx
Outdated
Show resolved
Hide resolved
laurakarhu
added
the
Breaking changes
NikoHelle
force-pushed
the
hds-2069-select-part-i
branch
from
bb2e048 to
ff6da96
Compare
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 37dc258. ♻️ This comment has been updated with latest results. |
The select button must show number of hidden elements. This util can find the last visible one.
The option list should close on outside click. Same feature has been used in other components, but no common hook has existed.
And a hook for using the DataProvider with Select data types.
Components trigger events that change the data. This is one common place for all events.
When an event is triggered, dataUpdater listens to them and changes Select component's data
NikoHelle
force-pushed
the
hds-2069-select-part-i
branch
from
ff6da96 to
37dc258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: target branch is another select component branch with its own PR.
Description
First commits for the Select component. Skeleton version with only single select and basic components.
Related Issue
https://helsinkisolutionoffice.atlassian.net/browse/HDS-2069
Motivation and Context
Making multiple PRs for the Select instead of one huge.
How Has This Been Tested?
Unit tests
Demo
Screenshots (if appropriate):
Add to changelog
Not until whole Select is ready