Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New source type: Image that uses Ra/DEC #57

Open
hamogu opened this issue Mar 2, 2023 · 2 comments
Open

New source type: Image that uses Ra/DEC #57

hamogu opened this issue Mar 2, 2023 · 2 comments

Comments

@hamogu
Copy link
Member

hamogu commented Mar 2, 2023

The existing image source only uses the pixel scale from the WCS in the image, but always assumes that the center of the input image is at the optical axis of marx. That's done as a convenience for a typical use case: Take an observed image from one source and use it as input to simulate the same spatial distribution, but a different detector, different exposure time, or different position on the sky.

However, that leads to annoying side effects:

  • The SourceRA and SourceDec setting have to be close to the pointing direction, but otherwise don't have any effect (IMAGE source: No checking of SourceRA and DEC needed #33).
  • You can't use the same image to simulate the effect of off-axis angles or roll angle, instead you need to make new images with the source being more and more off-center.
  • Input image from other wavelength need to be carefully scaled so that the object of interest sits at the right location.

So, I should make a new source class. Name open for discussion, but something like "S-Image-WCS".

@hamogu
Copy link
Member Author

hamogu commented Nov 21, 2023

This functionality is available through SIMPUT. Marx has a SIMPUT source and SIMPUT does provide exactly this functionality. It's a little more work to set up then using a build-in marx source, but I'd prefer not to duplicate existing functionality if I can avoid it.
While it's not hard in principle to modify the IMAGE source for this, there are restrictions: Which WCS systems should be supported? TAN projection is relatively easy, but how about others? Do I re-implement here or use WCSlib as an additional dependency?
I'll close this as "won't do", but it could be resurrected if a use case that cannot be covered by SIMPUT emerges.

@hamogu hamogu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
@hamogu
Copy link
Member Author

hamogu commented Nov 28, 2023

Hmm. If I build marx agains the CIAO libraries, then I have access to the WCSlib which would make this much easier to implement. In that case, it might be worthwhile to have this natively in marx without requiering SIMPUT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant