From 698259f3e03cf87a95b0f8aa2a034a8755d57138 Mon Sep 17 00:00:00 2001 From: mario4tier Date: Tue, 15 Oct 2024 16:07:14 -0400 Subject: [PATCH] CSS,ENV and Github Actions lint fixes --- .github/lint.env | 2 ++ .github/workflows/deploy-docs.yml | 6 +++--- .github/workflows/dev-nightly-tests.yml | 9 +++++---- .github/workflows/lint.yml | 2 +- .github/workflows/main-nightly-tests.yml | 8 ++++---- .github/workflows/release-tests.yml | 11 ++++++----- .github/workflows/rust-tests.yml | 9 +++++---- .github/workflows/scripts-tests.yml | 9 +++++---- .github/workflows/suibase-daemon-tests.yml | 11 ++++++----- .github/workflows/trig-rust-api-docs.yml | 2 -- typescript/vscode-extension/.env.development | 1 - typescript/vscode-extension/.env.production | 1 - 12 files changed, 37 insertions(+), 34 deletions(-) delete mode 100644 typescript/vscode-extension/.env.development delete mode 100644 typescript/vscode-extension/.env.production diff --git a/.github/lint.env b/.github/lint.env index 6320cea8..a7b57e7a 100644 --- a/.github/lint.env +++ b/.github/lint.env @@ -2,6 +2,8 @@ BASH_EXEC_IGNORE_LIBRARIES=true IGNORE_GITIGNORED_FILES=true NATURAL_LANGUAGE_CONFIG_FILE=.textlintrc.jsonc VALIDATE_CSHARP=false +VALIDATE_CSS=false +VALIDATE_CSS_PRETTIER=false VALIDATE_GO=false VALIDATE_GO_MODULES=false VALIDATE_GO_RELEASER=false diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml index 4572f8cc..383fed47 100644 --- a/.github/workflows/deploy-docs.yml +++ b/.github/workflows/deploy-docs.yml @@ -47,8 +47,8 @@ jobs: - name: Copy pnpm dependency files run: | - cp -f $GITHUB_WORKSPACE/docs/ci/pnpm-lock.yaml.ci $GITHUB_WORKSPACE/docs/pnpm-lock.yaml - cp -f $GITHUB_WORKSPACE/docs/ci/package.json.ci $GITHUB_WORKSPACE/docs/package.json + cp -f "$GITHUB_WORKSPACE/docs/ci/pnpm-lock.yaml.ci" "$GITHUB_WORKSPACE/docs/pnpm-lock.yaml" + cp -f "$GITHUB_WORKSPACE/docs/ci/package.json.ci" "$GITHUB_WORKSPACE/docs/package.json" - name: Setup Node.js uses: actions/setup-node@v4 @@ -60,7 +60,7 @@ jobs: - name: Build Docs env: NODE_OPTIONS: --max_old_space_size=8192 - run: |- + run: | cd docs pnpm run docs:build diff --git a/.github/workflows/dev-nightly-tests.yml b/.github/workflows/dev-nightly-tests.yml index 352119df..7df26aae 100644 --- a/.github/workflows/dev-nightly-tests.yml +++ b/.github/workflows/dev-nightly-tests.yml @@ -89,12 +89,13 @@ jobs: - name: Prepare environment run: | - mkdir -p $HOME/.local/bin - echo "$HOME/.local/bin" >> $GITHUB_PATH - ln -s $GITHUB_WORKSPACE $HOME/suibase + mkdir -p "$HOME/.local/bin" + echo "$HOME/.local/bin" >> "$GITHUB_PATH" + ln -s "$GITHUB_WORKSPACE" "$HOME/suibase" - name: Tests with Mysten Labs main branch (cutting edge) env: CI_BRANCH: ${{ matrix.ci_branch }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: $HOME/suibase/scripts/tests/run-all.sh --main_branch + run: | + "$HOME/suibase/scripts/tests/run-all.sh" --main_branch diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index ed1b0a99..105bb489 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -29,7 +29,7 @@ jobs: fetch-depth: 0 - name: Load environment variables from lint.env - run: grep -v '^#' .github/lint.env >> $GITHUB_ENV + run: grep -v '^#' .github/lint.env >> "$GITHUB_ENV" - name: Super-linter uses: super-linter/super-linter@v6.8.0 # x-release-please-version diff --git a/.github/workflows/main-nightly-tests.yml b/.github/workflows/main-nightly-tests.yml index 85de208e..cccfe6ca 100644 --- a/.github/workflows/main-nightly-tests.yml +++ b/.github/workflows/main-nightly-tests.yml @@ -11,7 +11,7 @@ on: jobs: test: - name: Test ${{ matrix.os }} ${{ matrix.ci_workdir }} + name: Test ${{ matrix.os }} runs-on: ${{ matrix.os }} strategy: matrix: @@ -68,9 +68,9 @@ jobs: - name: Prepare environment run: | - mkdir -p $HOME/.local/bin - echo "$HOME/.local/bin" >> $GITHUB_PATH - ln -s $GITHUB_WORKSPACE $HOME/suibase + mkdir -p "$HOME/.local/bin" + echo "$HOME/.local/bin" >> "$GITHUB_PATH" + ln -s "$GITHUB_WORKSPACE" "$HOME/suibase" - name: Exhaustive Tests of Suibase main branch (the only release branch). env: diff --git a/.github/workflows/release-tests.yml b/.github/workflows/release-tests.yml index 7330064d..90130318 100644 --- a/.github/workflows/release-tests.yml +++ b/.github/workflows/release-tests.yml @@ -20,7 +20,7 @@ on: jobs: test: - name: Test ${{ matrix.os }} ${{ matrix.ci_workdir }} + name: Test ${{ matrix.os }} runs-on: ${{ matrix.os }} strategy: matrix: @@ -42,11 +42,12 @@ jobs: - name: Prepare environment run: | - mkdir -p $HOME/.local/bin - echo "$HOME/.local/bin" >> $GITHUB_PATH - ln -s $GITHUB_WORKSPACE $HOME/suibase + mkdir -p "$HOME/.local/bin" + echo "$HOME/.local/bin" >> "$GITHUB_PATH" + ln -s "$GITHUB_WORKSPACE" "$HOME/suibase" - name: Only sanity tests the release env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: $HOME/suibase/scripts/tests/run-all.sh --release-tests + run: | + "$HOME/suibase/scripts/tests/run-all.sh" --release-tests diff --git a/.github/workflows/rust-tests.yml b/.github/workflows/rust-tests.yml index 18c4fc01..e7127f7f 100644 --- a/.github/workflows/rust-tests.yml +++ b/.github/workflows/rust-tests.yml @@ -95,13 +95,14 @@ jobs: - name: Prepare environment run: | - mkdir -p $HOME/.local/bin - echo "$HOME/.local/bin" >> $GITHUB_PATH - ln -s $GITHUB_WORKSPACE $HOME/suibase + mkdir -p "$HOME/.local/bin" + echo "$HOME/.local/bin" >> "$GITHUB_PATH" + ln -s "$GITHUB_WORKSPACE" "$HOME/suibase" - name: Run rust demo/api tests only env: CI_WORKDIR: ${{ matrix.ci_workdir }} CI_BRANCH: ${{ matrix.ci_branch }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: $HOME/suibase/scripts/tests/run-all.sh --rust-tests + run: | + "$HOME/suibase/scripts/tests/run-all.sh" --rust-tests diff --git a/.github/workflows/scripts-tests.yml b/.github/workflows/scripts-tests.yml index 6bd7dc3c..fa046c6e 100644 --- a/.github/workflows/scripts-tests.yml +++ b/.github/workflows/scripts-tests.yml @@ -63,11 +63,12 @@ jobs: - name: Prepare environment run: | - mkdir -p $HOME/.local/bin - echo "$HOME/.local/bin" >> $GITHUB_PATH - ln -s $GITHUB_WORKSPACE $HOME/suibase + mkdir -p "$HOME/.local/bin" + echo "$HOME/.local/bin" >> "$GITHUB_PATH" + ln -s "$GITHUB_WORKSPACE" "$HOME/suibase" - name: Run suibase CLI sanity tests only env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: $HOME/suibase/scripts/tests/run-all.sh --scripts-tests + run: | + "$HOME/suibase/scripts/tests/run-all.sh" --scripts-tests diff --git a/.github/workflows/suibase-daemon-tests.yml b/.github/workflows/suibase-daemon-tests.yml index a27ec73f..dbe61b29 100644 --- a/.github/workflows/suibase-daemon-tests.yml +++ b/.github/workflows/suibase-daemon-tests.yml @@ -30,7 +30,7 @@ jobs: retention-days: 1 test: - name: Test ${{ matrix.os }} ${{ matrix.ci_workdir }} + name: Test ${{ matrix.os }} needs: diff if: ${{ (needs.diff.outputs.isChanged == 'true') || (github.event_name == 'workflow_dispatch') }} @@ -84,14 +84,15 @@ jobs: - name: Prepare environment run: | - mkdir -p $HOME/.local/bin - echo "$HOME/.local/bin" >> $GITHUB_PATH - ln -s $GITHUB_WORKSPACE $HOME/suibase + mkdir -p "$HOME/.local/bin" + echo "$HOME/.local/bin" >> "$GITHUB_PATH" + ln -s "$GITHUB_WORKSPACE" "$HOME/suibase" - name: Run suibase rust apps only env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: $HOME/suibase/scripts/tests/run-all.sh --suibase-daemon-tests + run: | + "$HOME/suibase/scripts/tests/run-all.sh" --suibase-daemon-tests trig: needs: test diff --git a/.github/workflows/trig-rust-api-docs.yml b/.github/workflows/trig-rust-api-docs.yml index 1dd7891b..5d4e3466 100644 --- a/.github/workflows/trig-rust-api-docs.yml +++ b/.github/workflows/trig-rust-api-docs.yml @@ -18,8 +18,6 @@ jobs: - name: Detect Changes uses: "./.github/actions/diffs" id: diff - with: - ref: ${{ github.ref }} - name: Upload Trigger Artifact if: ${{ steps.diff.outputs.isDocHelperAPI == 'true' }} diff --git a/typescript/vscode-extension/.env.development b/typescript/vscode-extension/.env.development deleted file mode 100644 index d102baba..00000000 --- a/typescript/vscode-extension/.env.development +++ /dev/null @@ -1 +0,0 @@ -VITE_SSC_API_URL='http://127.0.0.1:3001/https://ssc.mhax.io' diff --git a/typescript/vscode-extension/.env.production b/typescript/vscode-extension/.env.production deleted file mode 100644 index 57c6e71a..00000000 --- a/typescript/vscode-extension/.env.production +++ /dev/null @@ -1 +0,0 @@ -VITE_SSC_API_URL="https://ssc.mhax.io"