From 3272b703bc6228f821a27ebe32a9bcb25b234481 Mon Sep 17 00:00:00 2001 From: futa-ikeda Date: Wed, 22 Jan 2025 12:27:18 -0500 Subject: [PATCH] Clean up unused/commented code --- .../-components/preprint-doi/component.ts | 4 ---- .../preprint-state-machine/component.ts | 2 -- app/preprints/new-version/route.ts | 20 ------------------- 3 files changed, 26 deletions(-) diff --git a/app/preprints/-components/preprint-doi/component.ts b/app/preprints/-components/preprint-doi/component.ts index 0256bd349d..88933967ec 100644 --- a/app/preprints/-components/preprint-doi/component.ts +++ b/app/preprints/-components/preprint-doi/component.ts @@ -1,8 +1,6 @@ -import { inject as service } from '@ember/service'; import { action } from '@ember/object'; import Component from '@glimmer/component'; import { tracked } from '@glimmer/tracking'; -import Intl from 'ember-intl/services/intl'; import PreprintModel, { VersionStatusSimpleLabelKey } from 'ember-osf-web/models/preprint'; import PreprintProviderModel from 'ember-osf-web/models/preprint-provider'; @@ -14,8 +12,6 @@ interface InputArgs { } export default class PreprintAbstract extends Component { - @service intl!: Intl; - provider = this.args.provider; documentType = this.provider.documentType.singularCapitalized; diff --git a/app/preprints/-components/submit/preprint-state-machine/component.ts b/app/preprints/-components/submit/preprint-state-machine/component.ts index 2591af2947..90a932b87a 100644 --- a/app/preprints/-components/submit/preprint-state-machine/component.ts +++ b/app/preprints/-components/submit/preprint-state-machine/component.ts @@ -15,7 +15,6 @@ import captureException, { getApiErrorMessage } from 'ember-osf-web/utils/captur import { Permission } from 'ember-osf-web/models/osf-model'; import { ReviewsState } from 'ember-osf-web/models/provider'; import InstitutionModel from 'ember-osf-web/models/institution'; -import CurrentUserService from 'ember-osf-web/services/current-user'; import { ReviewActionTrigger } from 'ember-osf-web/models/review-action'; export enum PreprintStatusTypeEnum { @@ -46,7 +45,6 @@ export default class PreprintStateMachine extends Component{ @service router!: RouterService; @service intl!: Intl; @service toast!: Toast; - @service currentUser!: CurrentUserService; titleAndAbstractValidation = false; fileValidation = false; diff --git a/app/preprints/new-version/route.ts b/app/preprints/new-version/route.ts index d7db18c1f0..93aef80741 100644 --- a/app/preprints/new-version/route.ts +++ b/app/preprints/new-version/route.ts @@ -2,8 +2,6 @@ import Store from '@ember-data/store'; import Route from '@ember/routing/route'; import RouterService from '@ember/routing/router-service'; import { inject as service } from '@ember/service'; -import Toast from 'ember-toastr/services/toast'; -import Intl from 'ember-intl/services/intl'; import Theme from 'ember-osf-web/services/theme'; import MetaTags, { HeadTagDef } from 'ember-osf-web/services/meta-tags'; @@ -14,9 +12,6 @@ export default class PreprintNewVersionRoute extends Route { @service theme!: Theme; @service router!: RouterService; @service metaTags!: MetaTags; - @service toast!: Toast; - @service intl!: Intl; - headTags?: HeadTagDef[]; @@ -36,21 +31,6 @@ export default class PreprintNewVersionRoute extends Route { const preprint: PreprintModel = await this.store.findRecord('preprint', args.guid); - // TODO: Re-evaluate if re-route logic is necessary - // if (!preprint.canCreateNewVersion) { - // let message = this.intl.t('preprints.submit.new-version.redirect.latest-published', - // { preprintWord: provider.documentType.singular }); - // if (!preprint.currentUserIsAdmin) { - // message = this.intl.t('preprints.submit.new-version.redirect.permission', - // { preprintWord: provider.documentType.singular }); - // } - - // const title = this.intl.t('preprints.submit.new-version.redirect.title'); - // this.toast.info(message, title); - // this.router.transitionTo('preprints.detail', args.provider_id, args.guid); - // return null; - // } - return { provider, preprint,