From e56fee62f6e0e9b77ffbb93a550e9d8eff3908eb Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Tue, 22 Oct 2024 16:45:20 -0700
Subject: [PATCH 01/23] add coverage to tests

---
 .github/workflows/test.yml | 34 ++++++++++++++++++++++++++++++----
 1 file changed, 30 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 3a1c827d..d204fff4 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -19,7 +19,6 @@ jobs:
       matrix:
         config:
           - python: "3.10"
-          - python: "3.11"
           - python: "3.12"
 
         split: [1, 2, 3, 4, 5, 6, 7, 8]
@@ -49,10 +48,37 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
-      - if: ${{ matrix.config.python == '3.11' && github.event_name == 'push' }}
-        name: codacy-coverage-reporter
+      - name: Upload coverage
+        if: ${{ matrix.config.python == '3.11' && github.event_name == 'push' }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage${{ matrix.group }}
+          path: .coverage
+
+  coverage:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python 3.11
+        uses: actions/setup-python@v5
+        with:
+          python-version: 3.11
+      - name: Install deps
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt
+      - name: Download all artifacts
+        # Downloads coverage1, coverage2, etc.
+        uses: actions/download-artifact@v2
+      - name: Run coverage
+        run: |
+          coverage combine coverage*/.coverage*
+          coverage report --fail-under=100
+          coverage xml
+      - name: codacy-coverage-reporter
         uses: codacy/codacy-coverage-reporter-action@v1
         with:
             project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}

From 4eda6e72be41dcb71beefa3719c81a59d9d80bf3 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Tue, 22 Oct 2024 17:02:21 -0700
Subject: [PATCH 02/23] add cov report

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index d204fff4..96063b94 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,7 +48,7 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.11' && github.event_name == 'push' }}

From 7bf56ffb1a6430ebd03fa26b83e6a29d41b07183 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Wed, 23 Oct 2024 08:32:46 -0700
Subject: [PATCH 03/23] v4 download

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 96063b94..c7f82249 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -72,7 +72,7 @@ jobs:
           pip install -r requirements.txt
       - name: Download all artifacts
         # Downloads coverage1, coverage2, etc.
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
       - name: Run coverage
         run: |
           coverage combine coverage*/.coverage*

From 7aff68da0cc600cce651a2d83f3c580e2b98ad2c Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Wed, 23 Oct 2024 12:48:54 -0700
Subject: [PATCH 04/23] install coverage

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index c7f82249..c979057a 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -69,7 +69,7 @@ jobs:
       - name: Install deps
         run: |
           python -m pip install --upgrade pip
-          pip install -r requirements.txt
+          pip install coverage
       - name: Download all artifacts
         # Downloads coverage1, coverage2, etc.
         uses: actions/download-artifact@v4

From 1ff5f5d7a3090f8d07ee636aeb631407f0285dcb Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Tue, 22 Oct 2024 16:45:20 -0700
Subject: [PATCH 05/23] add coverage to tests

---
 .github/workflows/test.yml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index c979057a..af4196a6 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,10 +48,10 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
-        if: ${{ matrix.config.python == '3.11' && github.event_name == 'push' }}
+        if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}
         uses: actions/upload-artifact@v4
         with:
           name: coverage${{ matrix.group }}
@@ -62,17 +62,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Python 3.11
+      - name: Set up Python 3.12
         uses: actions/setup-python@v5
         with:
-          python-version: 3.11
+          python-version: 3.12
       - name: Install deps
         run: |
           python -m pip install --upgrade pip
-          pip install coverage
+          pip install -r requirements.txt
       - name: Download all artifacts
         # Downloads coverage1, coverage2, etc.
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v2
       - name: Run coverage
         run: |
           coverage combine coverage*/.coverage*

From edcc4d16366022e22215d991f76be87746a8340b Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Tue, 22 Oct 2024 17:02:21 -0700
Subject: [PATCH 06/23] add cov report

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index af4196a6..c3e42d95 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,7 +48,7 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}

From 714fb3c0fb042f060c7f4d55968d69e4bdff5fa8 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Wed, 22 Jan 2025 09:13:59 -0800
Subject: [PATCH 07/23] fix typo

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index c3e42d95..309ed590 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,7 +48,7 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov-report --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}

From 494349c27415eb4bf6d64a259b6ae01aabf70124 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Wed, 22 Jan 2025 09:24:48 -0800
Subject: [PATCH 08/23] xml report

---
 .github/workflows/test.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 309ed590..878568c4 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,14 +48,15 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov-report --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov-report xml --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}
         uses: actions/upload-artifact@v4
         with:
-          name: coverage${{ matrix.group }}
+          name: coverage${{ matrix.group }}.xml
           path: .coverage
+          if-no-files-found: error
 
   coverage:
     needs: test

From ad693486b1e72a214ceccde5996455aa5c543994 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Fri, 31 Jan 2025 08:52:21 -0800
Subject: [PATCH 09/23] combine coverage results

---
 .github/workflows/test.yml | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 878568c4..e84a981e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -15,7 +15,6 @@ jobs:
   test:
     runs-on: ubuntu-latest
     strategy:
-      #max-parallel: 10
       matrix:
         config:
           - python: "3.10"
@@ -48,13 +47,13 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov-report xml --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}
         uses: actions/upload-artifact@v4
         with:
-          name: coverage${{ matrix.group }}.xml
+          name: .coverage${{ matrix.split }}
           path: .coverage
           if-no-files-found: error
 
@@ -67,16 +66,20 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: 3.12
-      - name: Install deps
+
+      - name: Install coverage
         run: |
           python -m pip install --upgrade pip
-          pip install -r requirements.txt
+          pip install coverage
+
       - name: Download all artifacts
         # Downloads coverage1, coverage2, etc.
         uses: actions/download-artifact@v2
+        with:
+          pattern: .coverage*
       - name: Run coverage
         run: |
-          coverage combine coverage*/.coverage*
+          coverage combine .coverage*
           coverage report --fail-under=100
           coverage xml
       - name: codacy-coverage-reporter

From e907aba23faa4db74b7881452462bee2baa489d4 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 20:23:00 -0800
Subject: [PATCH 10/23] fix cov

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e84a981e..92dfbf75 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -79,7 +79,7 @@ jobs:
           pattern: .coverage*
       - name: Run coverage
         run: |
-          coverage combine .coverage*
+          coverage combine coverage*/.coverage*
           coverage report --fail-under=100
           coverage xml
       - name: codacy-coverage-reporter

From 37665644a54a8cb3a67b4f82e648b4e5e5e6a3c5 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 20:38:22 -0800
Subject: [PATCH 11/23] ls la

---
 .github/workflows/test.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 92dfbf75..ee42bf07 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,6 +48,7 @@ jobs:
       - name: Test with pytest
         run: |
           pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          ls -la
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}

From 6bc9cfdb535cb40b43b19dff1a18909034b1b720 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 20:57:54 -0800
Subject: [PATCH 12/23] include hidden files

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ee42bf07..97c1b8ff 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -48,12 +48,12 @@ jobs:
       - name: Test with pytest
         run: |
           pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
-          ls -la
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}
         uses: actions/upload-artifact@v4
         with:
+          include-hidden-files: true
           name: .coverage${{ matrix.split }}
           path: .coverage
           if-no-files-found: error

From 8d685dd90a243e51afa383c1b77cc2971b22b0c9 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 20:58:18 -0800
Subject: [PATCH 13/23] update build

---
 .github/workflows/build.yml | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 496a58a4..374c97df 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -65,11 +65,13 @@ jobs:
           # supported macos version is: High Sierra / 10.13. When upgrading
           # this, be sure to update the MACOSX_DEPLOYMENT_TARGET environment
           # variable accordingly. Note that Darwin_17 == High Sierra / 10.13.
-          if [[ "$CIBW_ARCHS_MACOS" == arm64 ]]; then
-              # arm64 builds must cross compile because the CI instance is x86
-              # This turns off the computation of the test program in
-              # tools/build_helpers.py
-              echo "PYTHON_CROSSENV=1" >> "$GITHUB_ENV"
+          if [[ "$CIBW_BUILD" == *-macosx_arm64 ]]; then
+              if [[ $(uname -m) == "x86_64" ]]; then
+                # arm64 builds must cross compile because the CI instance is x86
+                # This turns off the computation of the test program in
+                # tools/build_helpers.py
+                echo "PYTHON_CROSSENV=1" >> "$GITHUB_ENV"
+              fi
 
               # SciPy requires 12.0 on arm to prevent kernel panics
               # https://github.com/scipy/scipy/issues/14688
@@ -84,8 +86,8 @@ jobs:
           # use conda to install llvm-openmp
           # Note that we do NOT activate the conda environment, we just add the
           # library install path to CFLAGS/CXXFLAGS/LDFLAGS below.
-          sudo conda create -n build $OPENMP_URL
-          PREFIX="/usr/local/miniconda/envs/build"
+          conda create -n build $OPENMP_URL
+          PREFIX="$HOME/miniconda/envs/build"
           echo "CC=/usr/bin/clang" >> "$GITHUB_ENV"
           echo "CPPFLAGS="$CPPFLAGS -Xpreprocessor -fopenmp"" >> "$GITHUB_ENV"
           echo "CFLAGS="$CFLAGS -Wno-implicit-function-declaration -I$PREFIX/include"" >> "$GITHUB_ENV"

From faf396469c187ed8e3f9eed75a7892ea5e8965eb Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 21:26:56 -0800
Subject: [PATCH 14/23] use download v4

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 97c1b8ff..9941030e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -75,7 +75,7 @@ jobs:
 
       - name: Download all artifacts
         # Downloads coverage1, coverage2, etc.
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
         with:
           pattern: .coverage*
       - name: Run coverage

From afffd19acf8446cdc1125bedc5d597ccf0018a85 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 21:34:34 -0800
Subject: [PATCH 15/23] use conda incubator

---
 .github/workflows/build.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 374c97df..73b9a529 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -42,6 +42,9 @@ jobs:
   build_wheels_macos:
     name: Build wheels on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
+    defaults:
+      run:
+        shell: bash -el {0}
     strategy:
       fail-fast: false
       matrix:
@@ -56,6 +59,11 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
+
+      - uses: conda-incubator/setup-miniconda@v3
+        with:
+          auto-update-conda: true
+
       - name: Setup openmp for macOS
         run: |
           # Make sure to use a libomp version binary compatible with the oldest

From 5c595611f80d29b3410a4398680ebecae386540f Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 21:47:44 -0800
Subject: [PATCH 16/23] export variables

---
 .github/workflows/build.yml | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 73b9a529..a48b06ab 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -96,10 +96,13 @@ jobs:
           # library install path to CFLAGS/CXXFLAGS/LDFLAGS below.
           conda create -n build $OPENMP_URL
           PREFIX="$HOME/miniconda/envs/build"
-          echo "CC=/usr/bin/clang" >> "$GITHUB_ENV"
-          echo "CPPFLAGS="$CPPFLAGS -Xpreprocessor -fopenmp"" >> "$GITHUB_ENV"
-          echo "CFLAGS="$CFLAGS -Wno-implicit-function-declaration -I$PREFIX/include"" >> "$GITHUB_ENV"
-          echo "LDFLAGS="$LDFLAGS -Wl,-S -Wl,-rpath,$PREFIX/lib -L$PREFIX/lib -lomp"" >> "$GITHUB_ENV"
+
+          export CC=/usr/bin/clang
+          export CXX=/usr/bin/clang++
+          export CPPFLAGS="$CPPFLAGS -Xpreprocessor -fopenmp"
+          export CFLAGS="$CFLAGS -I$PREFIX/include"
+          export CXXFLAGS="$CXXFLAGS -I$PREFIX/include"
+          export LDFLAGS="$LDFLAGS -Wl,-rpath,$PREFIX/lib -L$PREFIX/lib -lomp"
 
       - name: Build wheels
         uses: pypa/cibuildwheel@v2.22.0

From 7859afc0738cfb25967459defc8106e7951a89e0 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 22:07:23 -0800
Subject: [PATCH 17/23] add wheel names

---
 .github/workflows/build.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index a48b06ab..4fed44a2 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -37,6 +37,7 @@ jobs:
 
       - uses: actions/upload-artifact@v4
         with:
+          name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
           path: wheelhouse/*.whl
 
   build_wheels_macos:
@@ -109,6 +110,7 @@ jobs:
 
       - uses: actions/upload-artifact@v4
         with:
+          name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
           path: wheelhouse/*.whl
 
   build_sdist:

From 16a9572256d1ddb4dcca233d3bd32c7d09f94965 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 22:10:36 -0800
Subject: [PATCH 18/23] runs-on needs to be at the top

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 9941030e..4d2db94c 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -59,8 +59,8 @@ jobs:
           if-no-files-found: error
 
   coverage:
-    needs: test
     runs-on: ubuntu-latest
+    needs: test
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python 3.12

From e6f4e2a32b079e0a74f3c08db279c2845d96cf1c Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Sun, 2 Feb 2025 22:13:36 -0800
Subject: [PATCH 19/23] fix download path

---
 .github/workflows/test.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 4d2db94c..6c8ce3e4 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -80,7 +80,8 @@ jobs:
           pattern: .coverage*
       - name: Run coverage
         run: |
-          coverage combine coverage*/.coverage*
+          ls -la
+          coverage combine .coverage*
           coverage report --fail-under=100
           coverage xml
       - name: codacy-coverage-reporter

From b804190bbfb0ae0f64f36559a812fcb302d80570 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Mon, 3 Feb 2025 10:21:08 -0800
Subject: [PATCH 20/23] update coverage database file ending

---
 .github/workflows/test.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 6c8ce3e4..e47ab431 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -54,7 +54,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           include-hidden-files: true
-          name: .coverage${{ matrix.split }}
+          name: .coverage.${{ matrix.split }}
           path: .coverage
           if-no-files-found: error
 
@@ -81,7 +81,7 @@ jobs:
       - name: Run coverage
         run: |
           ls -la
-          coverage combine .coverage*
+          coverage combine .coverage.*
           coverage report --fail-under=100
           coverage xml
       - name: codacy-coverage-reporter

From f5e3d02f7d5ac105b40759666fd22e1c3586d162 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Mon, 3 Feb 2025 11:19:59 -0800
Subject: [PATCH 21/23] no cov report

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e47ab431..119ead62 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -47,7 +47,7 @@ jobs:
 
       - name: Test with pytest
         run: |
-          pytest --cov-report= --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
+          pytest --cov=smol --splits 8 --group ${{ matrix.split }} --durations-path tests/.test_durations tests
 
       - name: Upload coverage
         if: ${{ matrix.config.python == '3.12' && github.event_name == 'push' }}

From e149db08aae54826d6d4b19427dd12d0b11b92f7 Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Thu, 6 Feb 2025 08:25:18 -0800
Subject: [PATCH 22/23] use merge-multiple and a directory

---
 .github/workflows/test.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 119ead62..b305d570 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -54,7 +54,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           include-hidden-files: true
-          name: .coverage.${{ matrix.split }}
+          name: .coverage${{ matrix.split }}
           path: .coverage
           if-no-files-found: error
 
@@ -78,10 +78,12 @@ jobs:
         uses: actions/download-artifact@v4
         with:
           pattern: .coverage*
+          merge-multiple: true
+          path: coverage
       - name: Run coverage
         run: |
-          ls -la
-          coverage combine .coverage.*
+          ls -Ra
+          coverage combine coverage/.coverage*
           coverage report --fail-under=100
           coverage xml
       - name: codacy-coverage-reporter

From c04750b915036afbbcde5cf090474b40feba1f5d Mon Sep 17 00:00:00 2001
From: lbluque <lbluque@meta.com>
Date: Fri, 7 Feb 2025 07:26:57 -0800
Subject: [PATCH 23/23] no fail under

---
 .github/workflows/test.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index b305d570..ac54086c 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -82,10 +82,9 @@ jobs:
           path: coverage
       - name: Run coverage
         run: |
-          ls -Ra
           coverage combine coverage/.coverage*
-          coverage report --fail-under=100
           coverage xml
+        # coverage report --fail-under=85
       - name: codacy-coverage-reporter
         uses: codacy/codacy-coverage-reporter-action@v1
         with: