From 5e6a044b2579d29a13ecdff129e3e3d8a65a590b Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 25 Jun 2024 10:28:45 -0400 Subject: [PATCH 1/5] Bump minimum RuboCop version to 1.61 A few of our dependencies here have upped their supported RuboCop versions to v1.61: - rubocop-factory_bot - rubocop-rspec - rubocop-rspec_rails This commit does the same for this gem. --- Gemfile.lock | 2 +- rubocop-cargosense.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index db9b3a0..5db4373 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,7 +2,7 @@ PATH remote: . specs: rubocop-cargosense (1.1.0) - rubocop (~> 1.59) + rubocop (~> 1.61) rubocop-capybara (~> 2.20) rubocop-factory_bot (~> 2.25) rubocop-performance (~> 1.20) diff --git a/rubocop-cargosense.gemspec b/rubocop-cargosense.gemspec index 2b8a0c6..57d422c 100644 --- a/rubocop-cargosense.gemspec +++ b/rubocop-cargosense.gemspec @@ -25,7 +25,7 @@ Gem::Specification.new do |spec| "source_code_uri" => "#{spec.homepage}/tree/v#{spec.version}" } - spec.add_runtime_dependency "rubocop", "~> 1.59" + spec.add_runtime_dependency "rubocop", "~> 1.61" spec.add_runtime_dependency "rubocop-capybara", "~> 2.20" spec.add_runtime_dependency "rubocop-factory_bot", "~> 2.25" spec.add_runtime_dependency "rubocop-performance", "~> 1.20" From b44f760b204dbcae99a7380d432c37534036d77e Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 25 Jun 2024 10:43:58 -0400 Subject: [PATCH 2/5] Bump rubocop-rspec and rubocop-rspec_rails Closes #42 and #43 which wouldn't pass independent of one another. --- Gemfile.lock | 16 +++++++--------- rubocop-cargosense.gemspec | 4 ++-- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 5db4373..4e19cbf 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -8,8 +8,8 @@ PATH rubocop-performance (~> 1.20) rubocop-rails (~> 2.23) rubocop-rake (~> 0.6) - rubocop-rspec (~> 2.28) - rubocop-rspec_rails (~> 2.28.1) + rubocop-rspec (~> 3.0) + rubocop-rspec_rails (~> 2.30) GEM remote: https://rubygems.org/ @@ -76,13 +76,11 @@ GEM rubocop-ast (>= 1.31.1, < 2.0) rubocop-rake (0.6.0) rubocop (~> 1.0) - rubocop-rspec (2.29.2) - rubocop (~> 1.40) - rubocop-capybara (~> 2.17) - rubocop-factory_bot (~> 2.22) - rubocop-rspec_rails (~> 2.28) - rubocop-rspec_rails (2.28.3) - rubocop (~> 1.40) + rubocop-rspec (3.0.1) + rubocop (~> 1.61) + rubocop-rspec_rails (2.30.0) + rubocop (~> 1.61) + rubocop-rspec (~> 3, >= 3.0.1) ruby-progressbar (1.13.0) strscan (3.1.0) tzinfo (2.0.6) diff --git a/rubocop-cargosense.gemspec b/rubocop-cargosense.gemspec index 57d422c..4bd54cc 100644 --- a/rubocop-cargosense.gemspec +++ b/rubocop-cargosense.gemspec @@ -31,6 +31,6 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency "rubocop-performance", "~> 1.20" spec.add_runtime_dependency "rubocop-rails", "~> 2.23" spec.add_runtime_dependency "rubocop-rake", "~> 0.6" - spec.add_runtime_dependency "rubocop-rspec", "~> 2.28" - spec.add_runtime_dependency "rubocop-rspec_rails", "~> 2.28.1" + spec.add_runtime_dependency "rubocop-rspec", "~> 3.0" + spec.add_runtime_dependency "rubocop-rspec_rails", "~> 2.30" end From 76857eb509297558688845f184721b897b226eb3 Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 25 Jun 2024 14:51:28 +0000 Subject: [PATCH 3/5] Update rubocop-factory_bot constraint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The change to this gem's rubocop constraint (`~> 1.61`) was in v2.26.1. 🤦🏻‍♂️ --- Gemfile.lock | 2 +- rubocop-cargosense.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 4e19cbf..1ccd55e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -4,7 +4,7 @@ PATH rubocop-cargosense (1.1.0) rubocop (~> 1.61) rubocop-capybara (~> 2.20) - rubocop-factory_bot (~> 2.25) + rubocop-factory_bot (~> 2.26.1) rubocop-performance (~> 1.20) rubocop-rails (~> 2.23) rubocop-rake (~> 0.6) diff --git a/rubocop-cargosense.gemspec b/rubocop-cargosense.gemspec index 4bd54cc..1149318 100644 --- a/rubocop-cargosense.gemspec +++ b/rubocop-cargosense.gemspec @@ -27,7 +27,7 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency "rubocop", "~> 1.61" spec.add_runtime_dependency "rubocop-capybara", "~> 2.20" - spec.add_runtime_dependency "rubocop-factory_bot", "~> 2.25" + spec.add_runtime_dependency "rubocop-factory_bot", "~> 2.26.1" spec.add_runtime_dependency "rubocop-performance", "~> 1.20" spec.add_runtime_dependency "rubocop-rails", "~> 2.23" spec.add_runtime_dependency "rubocop-rake", "~> 0.6" From 68f09a446766ecaa8b6287ec70602937e91c01b9 Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 25 Jun 2024 14:56:30 +0000 Subject: [PATCH 4/5] Update rubocop-rspec constraint --- Gemfile.lock | 16 ++++++++-------- rubocop-cargosense.gemspec | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 1ccd55e..f11a565 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -8,7 +8,7 @@ PATH rubocop-performance (~> 1.20) rubocop-rails (~> 2.23) rubocop-rake (~> 0.6) - rubocop-rspec (~> 3.0) + rubocop-rspec (~> 3.0.1) rubocop-rspec_rails (~> 2.30) GEM @@ -47,7 +47,7 @@ GEM regexp_parser (2.9.2) rexml (3.3.1) strscan - rubocop (1.64.1) + rubocop (1.61.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -55,25 +55,25 @@ GEM rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.31.1, < 2.0) + rubocop-ast (>= 1.30.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.31.3) parser (>= 3.3.1.0) - rubocop-capybara (2.21.0) + rubocop-capybara (2.20.0) rubocop (~> 1.41) rubocop-factory_bot (2.26.1) rubocop (~> 1.61) rubocop-packaging (0.5.2) rubocop (>= 1.33, < 2.0) - rubocop-performance (1.21.1) + rubocop-performance (1.20.0) rubocop (>= 1.48.1, < 2.0) - rubocop-ast (>= 1.31.1, < 2.0) - rubocop-rails (2.25.0) + rubocop-ast (>= 1.30.0, < 2.0) + rubocop-rails (2.23.0) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) - rubocop-ast (>= 1.31.1, < 2.0) + rubocop-ast (>= 1.30.0, < 2.0) rubocop-rake (0.6.0) rubocop (~> 1.0) rubocop-rspec (3.0.1) diff --git a/rubocop-cargosense.gemspec b/rubocop-cargosense.gemspec index 1149318..e2a2fd8 100644 --- a/rubocop-cargosense.gemspec +++ b/rubocop-cargosense.gemspec @@ -31,6 +31,6 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency "rubocop-performance", "~> 1.20" spec.add_runtime_dependency "rubocop-rails", "~> 2.23" spec.add_runtime_dependency "rubocop-rake", "~> 0.6" - spec.add_runtime_dependency "rubocop-rspec", "~> 3.0" + spec.add_runtime_dependency "rubocop-rspec", "~> 3.0.1" spec.add_runtime_dependency "rubocop-rspec_rails", "~> 2.30" end From 7ea3aa81b7bbd030152d9c24a640ba5309518d3c Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 25 Jun 2024 14:58:34 +0000 Subject: [PATCH 5/5] Bump version to v2.0.0 --- Gemfile.lock | 2 +- rubocop-cargosense.gemspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index f11a565..5c108d2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - rubocop-cargosense (1.1.0) + rubocop-cargosense (2.0.0) rubocop (~> 1.61) rubocop-capybara (~> 2.20) rubocop-factory_bot (~> 2.26.1) diff --git a/rubocop-cargosense.gemspec b/rubocop-cargosense.gemspec index e2a2fd8..2344a1f 100644 --- a/rubocop-cargosense.gemspec +++ b/rubocop-cargosense.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |spec| spec.required_ruby_version = ">= 3.0" spec.name = "rubocop-cargosense" - spec.version = "1.1.0" + spec.version = "2.0.0" spec.authors = ["CargoSense"] spec.email = ["rubygems@cargosense.com"]