You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @riderx,
how do you want to proceed?
Do you need to keep the code as much aligned as possible to the forked repo or we can think about refactoring a bit?
I strongly suggest to proceed step by step in different PRs (my original PR was probably too complex to be accepted)
Refactor the native code in order to simplify classes and cleanup the code before implementing new logic.
Android
new AuthActivityViewModel to implement MVVM and extract logic form the Activity
new CryptoManager to extract crypto implementation from the Plugin
new Credentials model
iOS
new CryptoManager to extract crypto implementation from the Plugin
Hey @lubbo thanks for the prompt answer. We can refactor, i just already made some refactor, what is important is not making breaking changes in JS interface if additions make it optional.
Current problem
epicshaggy#89
Preferred solution
.
Alternative options
No response
Additional context
No response
Before submitting
Fastest way to get this feature added
The text was updated successfully, but these errors were encountered: