Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement better security by lubbo #39

Open
2 of 3 tasks
riderx opened this issue Feb 9, 2025 · 2 comments
Open
2 of 3 tasks

feat: Implement better security by lubbo #39

riderx opened this issue Feb 9, 2025 · 2 comments

Comments

@riderx
Copy link

riderx commented Feb 9, 2025

Current problem

epicshaggy#89

Preferred solution

.

Alternative options

No response

Additional context

No response

Before submitting

Fastest way to get this feature added

@lubbo
Copy link

lubbo commented Feb 10, 2025

Hi @riderx,
how do you want to proceed?
Do you need to keep the code as much aligned as possible to the forked repo or we can think about refactoring a bit?

I strongly suggest to proceed step by step in different PRs (my original PR was probably too complex to be accepted)

  1. Refactor the native code in order to simplify classes and cleanup the code before implementing new logic.
  • Android
    • new AuthActivityViewModel to implement MVVM and extract logic form the Activity
    • new CryptoManager to extract crypto implementation from the Plugin
    • new Credentials model
  • iOS
    • new CryptoManager to extract crypto implementation from the Plugin
    • new Credentials model
  1. Implement new biometric features

@riderx
Copy link
Author

riderx commented Feb 17, 2025

Hey @lubbo thanks for the prompt answer. We can refactor, i just already made some refactor, what is important is not making breaking changes in JS interface if additions make it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants