Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Memberships Handling #350

Open
Thatsmusic99 opened this issue Oct 16, 2024 · 4 comments
Open

External Memberships Handling #350

Thatsmusic99 opened this issue Oct 16, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Thatsmusic99
Copy link
Member

The table exists. I don't believe it.

Table ID: ctl00_ctl00_Main_AdminPageContent_rptGroups_ctl04_gvMemberships

@Thatsmusic99 Thatsmusic99 added the good first issue Good for newcomers label Oct 16, 2024
@Thatsmusic99
Copy link
Member Author

I might be stupid

@CarrotManMatt CarrotManMatt added the bug Something isn't working label Oct 16, 2024
@CarrotManMatt
Copy link
Member

CarrotManMatt commented Oct 16, 2024

Do you have the error message that was given?

@CarrotManMatt CarrotManMatt added enhancement New feature or request and removed bug Something isn't working labels Oct 16, 2024
@CarrotManMatt
Copy link
Member

Apologies, I misunderstood what this issue was requesting. Are you saying that the table on the Guild's website exists, and therefore we should add this to the make-member command?

@MattyTheHacker
Copy link
Member

essentially we previously didn't have external members, but now we do so we should add the external member table to the check, in the same way the standard membership is. Though the caveat to this is that most (if not all) external members do not have a card ID, so there'd need to be some extra check for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants