Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when string after ! is anything other than "important" #156

Closed
jameswilson opened this issue May 28, 2015 · 2 comments
Closed

Warn when string after ! is anything other than "important" #156

jameswilson opened this issue May 28, 2015 · 2 comments

Comments

@jameswilson
Copy link

Similar to issue #21. Would be nice to see support for this IE<=7 hack:

.selector { property: value !ie; }

Where !ie acts as an !important and the string after ! can be anything.

Currently it causes a parse error.

ERROR: Expected RBRACE at line X, col Y. This rule looks for recoverable syntax errors. (errors) Browsers: All

Similarly, sass uses !default so it would be nice to kind of detect for that, instead of blowing up.

@jameswilson jameswilson changed the title Support warning when string after ! is anything other than "important" Warn when string after ! is anything other than "important" May 28, 2015
@stubbornella
Copy link
Member

Why not use the * property hack?

.selector { *property: value; }

On Thu, May 28, 2015 at 9:11 AM, James Wilson [email protected]
wrote:

Similar to issue #21. Would be nice to see support for this IE<=7 hack:

.selector { property: value !ie; }

Where !ie acts as an !important and the string after ! can be anything.
Currently it causes a parse error.

ERROR: Expected RBRACE at line X, col Y. This rule looks for recoverable syntax errors. (errors) Browsers: All

Reply to this email directly or view it on GitHub:
#156

@jameswilson
Copy link
Author

You're right that is a valid workaround AND it doesn't throw any parsing errors! But certainly seeing selector { property: value !ie7andbelow; } is clearer than the star hack, particularly on aging projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants