-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make buttons for jumping to useful viewpoints in 3D plots #2
Comments
I'm going to take a look at this as well as controlling rotation with sliders. If anyone else has already started on this, let me know. |
I made some progress on this in 5be7c8e See commit message for a description of why this is still buggy and what I think might be going wrong (although I think this is a reasonable start): Start towards jumping to small multiple viewpoints on click. There are two major problems with current implementation. The first is that the second small multiple viewpoint is not set up yet (it is actually pretty tricky to get these viewpoints oriented correctly). The second is that sometimes the viewpoints get mixed up, expecially if clicking quickly. I think this comes down to weird effects of asynchronous function calls. There is no setView function for x3dom, so I loop through and call nextView and prevView multiple times to get to the desired view. I think this ocassionally screws up, but I am not sure exactly how to fix this yet. |
Note for future: I came across a page in the x3dom documentation that might be useful for this issue: http://doc.x3dom.org/tutorials/animationInteraction/viewpoint/index.html |
Good find Tim -- I must have missed this as I was focusing on a JS solution with the API. I had some free time this morning and changed the small multiples to work by setting the set_bind attribute and the reseting the view. As far as I can tell, this works great! The middle viewpoint is still not set up. Note that I merged gh-pages with master and committed this to the master branch. I have not merged this update with gh-pages as we should make sure the merge looks ok while the TAs are still looking at the visualization. Just don't want to totally break the gh-pages site if they are still grading... |
I merged this locally and it looked fine. I pushed these changes to gh-pages. The only remaining thing for this is to set up the middle viewpoint and maybe tweak the other viewpoints if you want to fine tune things. |
Jumping to views along each axis could be a useful feature if we end up sticking with 3D views. This should be possible with x3DOM API by defining and adding them as viewpoints.
The text was updated successfully, but these errors were encountered: