Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A BuildError variant for "wire is the wrong type" #1836

Open
doug-q opened this issue Jan 6, 2025 · 0 comments
Open

A BuildError variant for "wire is the wrong type" #1836

doug-q opened this issue Jan 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@doug-q
Copy link
Collaborator

doug-q commented Jan 6, 2025

We have the very useful Dataflow::get_wire_type but there is no appropriate BuildError variant for when this wire does not have the expected type. Let's add one.

I would suggest we also add an Other variant, with either a String or a Box<dyn Error> for use when similar situations arise in the future.
@doug-q doug-q added the enhancement New feature or request label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doug-q