Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 'onset_sec' time when loading a Midi performance with multiple parts #411

Open
C-Suhit opened this issue Jan 10, 2025 · 0 comments
Assignees

Comments

@C-Suhit
Copy link
Collaborator

C-Suhit commented Jan 10, 2025

Hello!
There seems to be an issue with the 'onset_sec' values between two different parts within a midi performance file when it is loaded with Partitura.

In the linked midi file below (github does not allow midi files to be uploaded when reporting an issue), the right hand and left hand piano parts are present in two separate part components when loaded using the 'load_performance_midi()'. However, when combining the two parts using either 'partitura.utils.ensure_notearray()' or by converting each part's notearray to a pandas dataframe and then combining them, there seems to be an offset in the onset_sec value of the second part (the left hand part). This is confirmed by also computing and looking at the piano roll.
For example, the first note of the left hand needs to occur at the onset_sec value of 1.6666 seconds , but occurs instead at 2.5 seconds.
Link to midi file: https://drive.google.com/file/d/1BwlnYQ0olTmuw2SiXSI64AHaV7O07GDs/view?usp=sharing

When the same midi file is loaded directly into a DAW however, there is no issue, and the left hand part plays correctly in sync with the right hand part.

Hope the information helps!

@huispaty huispaty self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants